Update Microsoft.Data.SqlClient version #40214
Conversation
ghost
added
the
area-infrastructure
|
Looks fine to me, but I'm interested in hearing if there are any other tests/scenarios we should try before check-in. |
| @@ -276,7 +276,7 @@ | |||
| <XunitExtensibilityCoreVersion>$(XunitVersion)</XunitExtensibilityCoreVersion> | |||
| <XunitExtensibilityExecutionVersion>$(XunitVersion)</XunitExtensibilityExecutionVersion> | |||
| <XUnitRunnerVisualStudioVersion>2.4.3</XUnitRunnerVisualStudioVersion> | |||
| <MicrosoftDataSqlClientVersion>1.0.19249.1</MicrosoftDataSqlClientVersion> | |||
| <MicrosoftDataSqlClientVersion>4.0.1</MicrosoftDataSqlClientVersion> | |||
There was a problem hiding this comment.
That's a big jump. Anything to keep an 👁️ out for @smitpatel @bricelam❔
There was a problem hiding this comment.
@smitpatel @bricelam any concerns here? @BrennanConroy any other testing I should do?
There was a problem hiding this comment.
🤷 Just make sure to make an announcement about potential breaking changes with the version update.
There was a problem hiding this comment.
The encrypt-by-default breaking change has been a bit of a hurdle for users. So yeah, definitely try and communicate that to users and encourage them to provide their feedback to the SqlClient team. 😉
There was a problem hiding this comment.
Should resolve #40207
I confirmed that https://github.com/dotnet/aspnetcore/blob/main/src/Caching/SqlServer/test/run-db-tests.ps1 passes after the update