Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support loading OIDC options from configuration (#42679) #42771

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

captainsafia
Copy link
Member

@captainsafia captainsafia commented Jul 18, 2022

Support setting options for OpenID Connect (OIDC) authentication providers via configuration and expand options supported by existing (.NET 7 Preview 5) JWT-bearer authentication providers.

Part of #42170 and fixes #42000.

Customer Impact

This change ands support for the options-from-config strategy to OIDC authentication providers, which are more frequently used by user apps and addresses gaps/bugs in the existing options-from-config strategy for JWT-bearer based authentication.

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Change is limited to authentication area in ASP.NET.

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

* Support loading OIDC options from configuration

* Address feedback from review

* Address review feedback

* Support fallbacks for all options and override lists

* Fix up Enum.Parse and default for Authority
@captainsafia captainsafia added old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels Servicing-consider Shiproom approval is required for the issue labels Jul 18, 2022
@ghost
Copy link

ghost commented Jul 18, 2022

Hi @captainsafia. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge.

To learn more about how to prepare a servicing PR click here.

@captainsafia captainsafia added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Jul 18, 2022
@captainsafia
Copy link
Member Author

Approved via email.

@captainsafia
Copy link
Member Author

@dotnet/aspnet-build Can I get help merging?

@wtgodbe wtgodbe merged commit c83c384 into release/7.0-preview7 Jul 18, 2022
@wtgodbe wtgodbe deleted the cs/backport-opts branch July 18, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
old-area-web-frameworks-do-not-use *DEPRECATED* This label is deprecated in favor of the area-mvc and area-minimal labels Servicing-approved Shiproom has approved the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants