Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some notes on testing trimming #48333

Merged
merged 2 commits into from
May 22, 2023
Merged

Conversation

amcasey
Copy link
Member

@amcasey amcasey commented May 19, 2023

Learnings from implementing #48295.

@amcasey amcasey requested review from JamesNK and eerhardt May 19, 2023 17:43
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label May 19, 2023
@ghost
Copy link

ghost commented May 19, 2023

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@amcasey
Copy link
Member Author

amcasey commented May 20, 2023

This may need to be updated when I figure out why CI doesn't like my test. 😆

Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fixing some links.

docs/Trimming.md Outdated Show resolved Hide resolved
docs/Trimming.md Outdated Show resolved Hide resolved
Co-authored-by: Eric Erhardt <[email protected]>
@amcasey amcasey enabled auto-merge (squash) May 22, 2023 21:08
@amcasey amcasey merged commit 8aa4a52 into dotnet:main May 22, 2023
@ghost ghost added this to the 8.0-preview5 milestone May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants