Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force full reload on popstate #54877

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Force full reload on popstate #54877

merged 2 commits into from
Apr 4, 2024

Conversation

halter73
Copy link
Member

@halter73 halter73 commented Apr 1, 2024

Fixes #54574

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-blazor Includes: Blazor, Razor Components label Apr 1, 2024
@halter73 halter73 marked this pull request as ready for review April 3, 2024 22:25
@halter73 halter73 requested a review from a team as a code owner April 3, 2024 22:25
Copy link
Member

@MackinnonBuck MackinnonBuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but let's hear back from others before merging 🙂

@halter73 halter73 merged commit 3e9b848 into main Apr 4, 2024
27 checks passed
@halter73 halter73 deleted the halter73/54574 branch April 4, 2024 20:22
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-preview4 milestone Apr 4, 2024
@halter73
Copy link
Member Author

halter73 commented Apr 4, 2024

/backport to release/8.0

Copy link
Contributor

github-actions bot commented Apr 4, 2024

Started backporting to release/8.0: https://github.com/dotnet/aspnetcore/actions/runs/8560870102

Copy link
Contributor

github-actions bot commented Apr 4, 2024

@halter73 backporting to release/8.0 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Update package-lock.json
Using index info to reconstruct a base tree...
A	package-lock.json
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): package-lock.json deleted in HEAD and modified in Update package-lock.json. Version Update package-lock.json of package-lock.json left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Update package-lock.json
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

Copy link
Contributor

github-actions bot commented Apr 4, 2024

@halter73 an error occurred while backporting to release/8.0, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Hard reload not triggered when navigating from Interactive page to SSR page via browser back button
3 participants