[Infrastructure] Unblock installer #55358

javiercn · 2024-04-25T12:58:31Z

Split some changes from
#55339
To unblock
dotnet/installer#19577

src/Servers/Kestrel/Core/src/KestrelServerOptions.cs

kasperk81 · 2024-04-25T13:11:14Z

null-conditional operator ?[] is a correct replacement for FirstOrDefault

src/Identity/Specification.Tests/src/UserManagerSpecificationTests.cs

javiercn · 2024-04-25T13:17:19Z

null-conditional operator ?[] is a correct replacement for FirstOrDefault

kasperk81 · 2024-04-25T13:43:17Z

nvm, i was read it wrong

tannergooding · 2024-04-25T14:35:26Z

Commented here as well: dotnet/installer#19577 (comment), but the simpler fix here is to put CA1826.severity (

aspnetcore/.editorconfig

Line 149 in 08e84a2

    
           # CA1826: Do not use Enumerable methods on indexable collections. Instead use the collection directly

) back to its default, which is suggestion.

The linked comment has some context about the intent of the analyzer and why it can potentially be viewed as deprecated moving forward.

src/Identity/Specification.Tests/src/UserManagerSpecificationTests.cs

tannergooding · 2024-04-25T14:40:57Z

Does this PR need to also handle

error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Build) The "RepoTasks.RemoveSharedFrameworkDependencies" task failed unexpectedly.
System.MissingMethodException: Method not found: 'Boolean System.Collections.Generic.ISet1.Contains(!0)'. at RepoTasks.RemoveSharedFrameworkDependencies.FilterDependencies(String targetPath, ISet1 dependencyToRemove)
at RepoTasks.RemoveSharedFrameworkDependencies.Execute() in /_/src/aspnetcore/eng/tools/RepoTasks/RemoveSharedFrameworkDependencies.cs:line 38
at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask)

Which is also occurring in the blocked installer build: https://github.com/dotnet/installer/pull/19577/checks?check_run_id=24250325560

From the other PR, it sounds like this is due to project not use the shared framework workaround and so its compiling against an out of date BCL?

javiercn · 2024-04-25T14:42:50Z

Does this PR need to also handle

error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Build) The "RepoTasks.RemoveSharedFrameworkDependencies" task failed unexpectedly.
System.MissingMethodException: Method not found: 'Boolean System.Collections.Generic.ISet1.Contains(!0)'. at RepoTasks.RemoveSharedFrameworkDependencies.FilterDependencies(String targetPath, ISet1 dependencyToRemove)
at RepoTasks.RemoveSharedFrameworkDependencies.Execute() in /_/src/aspnetcore/eng/tools/RepoTasks/RemoveSharedFrameworkDependencies.cs:line 38
at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask)

Which is also occurring in the blocked installer build: https://github.com/dotnet/installer/pull/19577/checks?check_run_id=24250325560

From the other PR, it sounds like this is due to project not use the shared framework workaround and so its compiling against an out of date BCL?

I'm not sure, @wtgodbe will know best.

javiercn · 2024-04-25T14:43:14Z

I've created a separate PR #55361 to change the rule to suggestion

javiercn · 2024-04-25T14:47:31Z

Does this PR need to also handle

error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Build) The "RepoTasks.RemoveSharedFrameworkDependencies" task failed unexpectedly.
System.MissingMethodException: Method not found: 'Boolean System.Collections.Generic.ISet1.Contains(!0)'. at RepoTasks.RemoveSharedFrameworkDependencies.FilterDependencies(String targetPath, ISet1 dependencyToRemove)
at RepoTasks.RemoveSharedFrameworkDependencies.Execute() in /_/src/aspnetcore/eng/tools/RepoTasks/RemoveSharedFrameworkDependencies.cs:line 38
at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask)

Which is also occurring in the blocked installer build: https://github.com/dotnet/installer/pull/19577/checks?check_run_id=24250325560

From the other PR, it sounds like this is due to project not use the shared framework workaround and so its compiling against an out of date BCL?

I think you are right, we also need a change with the build infrastructure change. I'm not familiar with that area so I think we'll need @wtgodbe for that. I'm not sure if we can separate that change into its own change that runs with the current SDK so that we can merge it and make things flow, get a new installer and then update other PRs with it.

wtgodbe · 2024-04-25T14:50:45Z

Here's a hacky workaround to fix the RepoTasks issue: https://github.com/dotnet/aspnetcore/pull/55339/files#diff-c86671b0d4350666f7a867a36dd59de3723a6c8288eed724bc6dc2dac3a37990L67

The runtime dependency update is blocked by some test failures and other issues, so we should just port the above to here to unblock installer

* Cleanups

javiercn · 2024-04-25T15:16:58Z

@wtgodbe I've applied your suggestion here

* Fixes to analyzers and build infrastructure.

…/runtime (#55372) * Update dependencies from https://github.com/dotnet/runtime build 20240425.7 Microsoft.Bcl.AsyncInterfaces , Microsoft.Bcl.TimeProvider , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.Diagnostics , Microsoft.Extensions.Diagnostics.Abstractions , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Http , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.Platforms , System.Collections.Immutable , System.Composition , System.Configuration.ConfigurationManager , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices.Protocols , System.IO.Hashing , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Reflection.Metadata , System.Resources.Extensions , System.Runtime.Caching , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Threading.Channels , System.Threading.RateLimiting , Microsoft.SourceBuild.Intermediate.runtime.linux-x64 From Version 9.0.0-preview.4.24222.10 -> To Version 9.0.0-preview.4.24225.7 * Update dependencies from https://github.com/dotnet/efcore build 20240426.1 dotnet-ef , Microsoft.EntityFrameworkCore , Microsoft.EntityFrameworkCore.Design , Microsoft.EntityFrameworkCore.InMemory , Microsoft.EntityFrameworkCore.Relational , Microsoft.EntityFrameworkCore.Sqlite , Microsoft.EntityFrameworkCore.SqlServer , Microsoft.EntityFrameworkCore.Tools From Version 9.0.0-preview.5.24223.1 -> To Version 9.0.0-preview.4.24226.1 * Update the severity of CA1826 to suggestion Update the severity of CA1826 to suggestion as it's not really applicable in modern TFMs (#55361) * [Infrastructure] Unblock installer (#55358) * Fixes to analyzers and build infrastructure. * Update dependencies from https://github.com/dotnet/runtime build 20240427.4 Microsoft.Bcl.AsyncInterfaces , Microsoft.Bcl.TimeProvider , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.Diagnostics , Microsoft.Extensions.Diagnostics.Abstractions , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Http , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.Platforms , System.Collections.Immutable , System.Composition , System.Configuration.ConfigurationManager , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices.Protocols , System.IO.Hashing , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Reflection.Metadata , System.Resources.Extensions , System.Runtime.Caching , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Threading.Channels , System.Threading.RateLimiting , Microsoft.SourceBuild.Intermediate.runtime.linux-x64 From Version 9.0.0-preview.4.24222.10 -> To Version 9.0.0-preview.4.24227.4 * fix reflection * readonly * Update dependencies from https://github.com/dotnet/runtime build 20240430.10 Microsoft.Bcl.AsyncInterfaces , Microsoft.Bcl.TimeProvider , Microsoft.Extensions.Caching.Abstractions , Microsoft.Extensions.Caching.Memory , Microsoft.Extensions.Configuration , Microsoft.Extensions.Configuration.Abstractions , Microsoft.Extensions.Configuration.Binder , Microsoft.Extensions.Configuration.CommandLine , Microsoft.Extensions.Configuration.EnvironmentVariables , Microsoft.Extensions.Configuration.FileExtensions , Microsoft.Extensions.Configuration.Ini , Microsoft.Extensions.Configuration.Json , Microsoft.Extensions.Configuration.UserSecrets , Microsoft.Extensions.Configuration.Xml , Microsoft.Extensions.DependencyInjection , Microsoft.Extensions.DependencyInjection.Abstractions , Microsoft.Extensions.DependencyModel , Microsoft.Extensions.Diagnostics , Microsoft.Extensions.Diagnostics.Abstractions , Microsoft.Extensions.FileProviders.Abstractions , Microsoft.Extensions.FileProviders.Composite , Microsoft.Extensions.FileProviders.Physical , Microsoft.Extensions.FileSystemGlobbing , Microsoft.Extensions.HostFactoryResolver.Sources , Microsoft.Extensions.Hosting , Microsoft.Extensions.Hosting.Abstractions , Microsoft.Extensions.Http , Microsoft.Extensions.Logging , Microsoft.Extensions.Logging.Abstractions , Microsoft.Extensions.Logging.Configuration , Microsoft.Extensions.Logging.Console , Microsoft.Extensions.Logging.Debug , Microsoft.Extensions.Logging.EventLog , Microsoft.Extensions.Logging.EventSource , Microsoft.Extensions.Logging.TraceSource , Microsoft.Extensions.Options , Microsoft.Extensions.Options.ConfigurationExtensions , Microsoft.Extensions.Options.DataAnnotations , Microsoft.Extensions.Primitives , Microsoft.Internal.Runtime.AspNetCore.Transport , Microsoft.NET.Runtime.MonoAOTCompiler.Task , Microsoft.NET.Runtime.WebAssembly.Sdk , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.AOT.win-x64.Cross.browser-wasm , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.BrowserDebugHost.Transport , Microsoft.NETCore.Platforms , System.Collections.Immutable , System.Composition , System.Configuration.ConfigurationManager , System.Diagnostics.DiagnosticSource , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices.Protocols , System.IO.Hashing , System.IO.Pipelines , System.Net.Http.Json , System.Net.Http.WinHttpHandler , System.Reflection.Metadata , System.Resources.Extensions , System.Runtime.Caching , System.Security.Cryptography.Pkcs , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceProcess.ServiceController , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Threading.Channels , System.Threading.RateLimiting , Microsoft.SourceBuild.Intermediate.runtime.linux-x64 From Version 9.0.0-preview.4.24222.10 -> To Version 9.0.0-preview.4.24230.10 --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Javier Calvarro Nelson <[email protected]> Co-authored-by: Brennan <[email protected]>

javiercn added 3 commits April 25, 2024 14:57

Fix build break

f378de3

More break fixes

edeb545

More break fixes

33c3af9

dotnet-issue-labeler bot added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Apr 25, 2024

javiercn mentioned this pull request Apr 25, 2024

[main] Update dependencies from dotnet/sdk dotnet/installer#19577

Closed

javiercn commented Apr 25, 2024

View reviewed changes

src/Servers/Kestrel/Core/src/KestrelServerOptions.cs Show resolved Hide resolved

javiercn commented Apr 25, 2024

View reviewed changes

src/Identity/Specification.Tests/src/UserManagerSpecificationTests.cs Show resolved Hide resolved

TylerBrinkley approved these changes Apr 25, 2024

View reviewed changes

tannergooding reviewed Apr 25, 2024

View reviewed changes

src/Identity/Specification.Tests/src/UserManagerSpecificationTests.cs Outdated Show resolved Hide resolved

javiercn marked this pull request as ready for review April 25, 2024 14:43

javiercn requested review from halter73, BrennanConroy, JamesNK, mgravell and a team as code owners April 25, 2024 14:43

* Add workaround for shared framework dependencies

7c03168

* Cleanups

javiercn requested review from wtgodbe and a team as code owners April 25, 2024 15:15

Cleanups

c150b72

javiercn enabled auto-merge (squash) April 25, 2024 15:17

wtgodbe approved these changes Apr 25, 2024

View reviewed changes

javiercn merged commit 8951d73 into main Apr 25, 2024
26 checks passed

javiercn deleted the javiercn/unblock-installer-04-25-2024 branch April 25, 2024 17:12

dotnet-policy-service bot added this to the 9.0-preview5 milestone Apr 25, 2024

mthalman mentioned this pull request Apr 29, 2024

[release/9.0.1xx-preview4] Update dependencies from dotnet/sdk dotnet/installer#19584

Merged

wtgodbe pushed a commit that referenced this pull request Apr 29, 2024

[Infrastructure] Unblock installer (#55358)

f9c8cce

* Fixes to analyzers and build infrastructure.

wtgodbe mentioned this pull request May 15, 2024

Undo RemoveSharedFrameworkDependencies workaround #55739

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Infrastructure] Unblock installer #55358

[Infrastructure] Unblock installer #55358

javiercn commented Apr 25, 2024 •

edited

Loading

kasperk81 commented Apr 25, 2024

javiercn commented Apr 25, 2024

kasperk81 commented Apr 25, 2024

tannergooding commented Apr 25, 2024

tannergooding commented Apr 25, 2024

javiercn commented Apr 25, 2024

javiercn commented Apr 25, 2024

javiercn commented Apr 25, 2024

wtgodbe commented Apr 25, 2024

javiercn commented Apr 25, 2024

[Infrastructure] Unblock installer #55358

[Infrastructure] Unblock installer #55358

Conversation

javiercn commented Apr 25, 2024 • edited Loading

kasperk81 commented Apr 25, 2024

javiercn commented Apr 25, 2024

kasperk81 commented Apr 25, 2024

tannergooding commented Apr 25, 2024

tannergooding commented Apr 25, 2024

javiercn commented Apr 25, 2024

javiercn commented Apr 25, 2024

javiercn commented Apr 25, 2024

wtgodbe commented Apr 25, 2024

javiercn commented Apr 25, 2024

javiercn commented Apr 25, 2024 •

edited

Loading