Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Kestrel host header mismatch handling when port in Url #59352

Merged
merged 2 commits into from
Dec 9, 2024

avoid some allocs

e36d998
Select commit
Loading
Failed to load commit list.
Merged

Fix Kestrel host header mismatch handling when port in Url #59352

avoid some allocs
e36d998
Select commit
Loading
Failed to load commit list.
Azure Pipelines / aspnetcore-quarantined-pr succeeded Dec 7, 2024 in 56m 35s

Build #20241206.12 had test failures

Details

Tests

  • Failed: 7 (0.55%)
  • Passed: 1,240 (97.87%)
  • Other: 20 (1.58%)
  • Total: 1,267

Annotations

Check failure on line 273 in .dotnet/sdk/10.0.100-alpha.1.24573.1/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets

See this annotation in the file changed.

@azure-pipelines azure-pipelines / aspnetcore-quarantined-pr

.dotnet/sdk/10.0.100-alpha.1.24573.1/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets#L273

.dotnet/sdk/10.0.100-alpha.1.24573.1/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(273,5): error NETSDK1085: (NETCORE_ENGINEERING_TELEMETRY=Build) The 'NoBuild' property was set to true but the 'Build' target was invoked.

Check failure on line 273 in .dotnet/sdk/10.0.100-alpha.1.24573.1/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets

See this annotation in the file changed.

@azure-pipelines azure-pipelines / aspnetcore-quarantined-pr

.dotnet/sdk/10.0.100-alpha.1.24573.1/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets#L273

.dotnet/sdk/10.0.100-alpha.1.24573.1/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.targets(273,5): error NETSDK1085: (NETCORE_ENGINEERING_TELEMETRY=Build) The 'NoBuild' property was set to true but the 'Build' target was invoked.

Check failure on line 0 in ILLink

See this annotation in the file changed.

@azure-pipelines azure-pipelines / aspnetcore-quarantined-pr

ILLink#L0

ILLink(0,0): error IL1032: (NETCORE_ENGINEERING_TELEMETRY=Build) Root assembly 'obj/Release/net10.0/linux-x64/project.dll' could not be found.

Check failure on line 97 in .packages/microsoft.net.illink.tasks/10.0.0-alpha.1.24570.9/build/Microsoft.NET.ILLink.targets

See this annotation in the file changed.

@azure-pipelines azure-pipelines / aspnetcore-quarantined-pr

.packages/microsoft.net.illink.tasks/10.0.0-alpha.1.24570.9/build/Microsoft.NET.ILLink.targets#L97

.packages/microsoft.net.illink.tasks/10.0.0-alpha.1.24570.9/build/Microsoft.NET.ILLink.targets(97,5): error NETSDK1144: (NETCORE_ENGINEERING_TELEMETRY=Build) Optimizing assemblies for size failed.

Check failure on line 1 in ServerComparison.FunctionalTests.HelloWorldTests.HelloWorld

See this annotation in the file changed.

@azure-pipelines azure-pipelines / aspnetcore-quarantined-pr

ServerComparison.FunctionalTests.HelloWorldTests.HelloWorld

Test failed

Check failure on line 1 in Microsoft.AspNetCore.Hosting.HostingEventSourceTests.VerifyCountersFireWithCorrectValues

See this annotation in the file changed.

@azure-pipelines azure-pipelines / aspnetcore-quarantined-pr

Microsoft.AspNetCore.Hosting.HostingEventSourceTests.VerifyCountersFireWithCorrectValues

System.InvalidOperationException : Results ended with final value of 0. Expected value of 1.
---- System.OperationCanceledException : The operation was canceled.
Raw output
   at System.Collections.Generic.AsyncEnumerableExtensions.WaitForValueAsync[T](IAsyncEnumerator`1 values, T expectedValue) in /_/src/Hosting/Hosting/test/Internal/AsyncEnumerableExtensions.cs:line 28
   at Microsoft.AspNetCore.Hosting.HostingEventSourceTests.VerifyCountersFireWithCorrectValues() in /_/src/Hosting/Hosting/test/Internal/HostingEventSourceTests.cs:line 212
--- End of stack trace from previous location ---
----- Inner Stack Trace -----
   at System.Threading.Channels.AsyncOperation`1.GetResult(Int16 token)
   at System.Threading.Channels.ChannelReader`1.ReadAllAsync(CancellationToken cancellationToken)+MoveNext()
   at System.Threading.Channels.ChannelReader`1.ReadAllAsync(CancellationToken cancellationToken)+System.Threading.Tasks.Sources.IValueTaskSource<System.Boolean>.GetResult()
   at System.Collections.Generic.AsyncEnumerableExtensions.WaitForValueAsync[T](IAsyncEnumerator`1 values, T expectedValue) in /_/src/Hosting/Hosting/test/Internal/AsyncEnumerableExtensions.cs:line 15

Check failure on line 1 in Microsoft.AspNetCore.Server.Kestrel.Sockets.FunctionalTests.ResponseTests.ClientAbortingConnectionImmediatelyIsNotLoggedHigherThanDebug

See this annotation in the file changed.

@azure-pipelines azure-pipelines / aspnetcore-quarantined-pr

Microsoft.AspNetCore.Server.Kestrel.Sockets.FunctionalTests.ResponseTests.ClientAbortingConnectionImmediatelyIsNotLoggedHigherThanDebug

Test failed

Check failure on line 1 in Microsoft.AspNetCore.SignalR.Client.FunctionalTests.HubConnectionTests.ChangingUserNameDuringReconnectLogsWarning

See this annotation in the file changed.

@azure-pipelines azure-pipelines / aspnetcore-quarantined-pr

Microsoft.AspNetCore.SignalR.Client.FunctionalTests.HubConnectionTests.ChangingUserNameDuringReconnectLogsWarning

1 error(s) logged.
Microsoft.AspNetCore.Http.Connections.Client.Internal.WebSocketsTransport - ErrorSendingMessage - Error while sending a message.
===================
System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'System.Net.WebSockets.ClientWebSocket'.
   at System.Net.WebSockets.ClientWebSocket.get_ConnectedWebSocket()
   at System.Net.WebSockets.ClientWebSocket.SendAsync(ReadOnlyMemory`1 buffer, WebSocketMessageType messageType, Boolean endOfMessage, CancellationToken cancellationToken)
   at System.Net.WebSockets.WebSocketExtensions.SendAsync(WebSocket webSocket, ReadOnlySequence`1 buffer, WebSocketMessageType webSocketMessageType, CancellationToken cancellationToken) in /_/src/SignalR/common/Shared/WebSocketExtensions.cs:line 19
   at Microsoft.AspNetCore.Http.Connections.Client.Internal.WebSocketsTransport.StartSending(WebSocket socket, Boolean ignoreFirstCanceled) in /_/src/SignalR/clients/csharp/Http.Connections.Client/src/Internal/WebSocketsTransport.cs:line 562
===================
Raw output
   at Microsoft.AspNetCore.SignalR.Tests.VerifyNoErrorsScope.Dispose() in D:\a\_work\1\s\src\Shared\SignalR\VerifyNoErrorScope.cs:line 47
   at Microsoft.AspNetCore.SignalR.Tests.InProcessTestServer`1.DisposeAsync() in D:\a\_work\1\s\src\Shared\SignalR\InProcessTestServer.cs:line 161
   at Microsoft.AspNetCore.SignalR.Tests.InProcessTestServer`1.DisposeAsync() in D:\a\_work\1\s\src\Shared\SignalR\InProcessTestServer.cs:line 168
   at Microsoft.AspNetCore.SignalR.Client.FunctionalTests.HubConnectionTests.ChangingUserNameDuringReconnectLogsWarning() in /_/src/SignalR/clients/csharp/Client/test/FunctionalTests/HubConnectionTests.cs:line 2748
--- End of stack trace from previous location ---