Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sample frontmatter #21

Merged
merged 1 commit into from
Jun 22, 2022
Merged

Fix sample frontmatter #21

merged 1 commit into from
Jun 22, 2022

Conversation

jongalloway
Copy link
Contributor

Change razor to cshtml since razor is not in the list of languages for samples. This is causing an error that prevents listing in the Docs / Samples browser.

Change `razor` to `cshtml` since razor is not in the list of languages for samples.
@jongalloway
Copy link
Contributor Author

@jamesmontemagno @Rick-Anderson @guardrex for review

@guardrex
Copy link
Collaborator

guardrex commented Jun 22, 2022

Why isn't the solution to add razor to the list of languages for samples?

Whatever the case with that, there isn't any cshtml here, per se. I think we'd drop that as a language because anyone filtering for it and finding this repo won't find anything significant in these samples. Just about everything here focuses on Razor components (.razor).

Ah ... that's ok. I mean ... yeah ... there's a smidgen ... _Layout.cshtml, _Host.cshtml, and Error.cshtml. It's not a focus, but that's ok.

Alright, let's go ahead. I hope that they'll add razor as a language later.

Thanks for your help, @jongalloway! 🎷

@guardrex guardrex self-assigned this Jun 22, 2022
@guardrex guardrex merged commit 2ae54c7 into dotnet:main Jun 22, 2022
@jongalloway
Copy link
Contributor Author

I agree, I'll request to get razor added as a supported language. Just fixing the build errors to get it live first.

@jongalloway jongalloway deleted the patch-1 branch June 29, 2022 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants