Update to support both .NET and .NET Core branding #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@joeloff can I get a quick review here too? |
joeloff
reviewed
Sep 8, 2021
| @@ -72,7 +72,7 @@ internal static bool IsNetCoreBundle(string displayName, string displayVersion, | |||
| (displayName.IndexOf("Visual Studio", StringComparison.OrdinalIgnoreCase) < 0) && | |||
| (displayName.IndexOf("VS 2015", StringComparison.OrdinalIgnoreCase) < 0) && | |||
| (displayName.IndexOf("Local Feed", StringComparison.OrdinalIgnoreCase) < 0) && | |||
| ((displayName.IndexOf(".NET Core", StringComparison.OrdinalIgnoreCase) >= 0) || | |||
| ((displayName.IndexOf(".NET", StringComparison.OrdinalIgnoreCase) >= 0) || | |||
There was a problem hiding this comment.
Does this risk pickup on .NET Framework items? I don't think it should since .NET FX is part of Windows, but I have seen products call out other products like "XYZ for .NET 4.6". Something we can maybe look into later
joeloff
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #186