-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration: Promote ProjectReferences and Reference items #6974
Comments
Set PrivateAssets All on all promoted refs. See Here: dotnet/project-system#199 |
Project A -> Project B -> Project C, this is not supported by the SDK because it does not handle transitive dependencies. |
@livarcocc Was https://github.com/dotnet/cli/issues/4414#issuecomment-253925947 (set private assets on promoted refs) addressed with the fix? I'm not seeing it. cc @joelverhagen |
If not and pack is generating too many dependencies, we can infer private assets from FromP2P in the SDK to make things retroactively work on already migrated projects. |
@nguerrera No, it was not added. And that is a mistake. It should have been. I can add this going forward, if necessary. But if you can handle it using the FromP2P, that would be good too. |
Promote ProjectReferences and Reference items all the way up transitive references.
Workaround for:
dotnet/project-system#199
The text was updated successfully, but these errors were encountered: