Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration: Promote ProjectReferences and Reference items #6974

Closed
brthor opened this issue Oct 14, 2016 · 5 comments
Closed

Migration: Promote ProjectReferences and Reference items #6974

brthor opened this issue Oct 14, 2016 · 5 comments
Assignees

Comments

@brthor
Copy link
Contributor

brthor commented Oct 14, 2016

Promote ProjectReferences and Reference items all the way up transitive references.

Workaround for:
dotnet/project-system#199

@brthor
Copy link
Contributor Author

brthor commented Oct 14, 2016

Set PrivateAssets All on all promoted refs.

See Here: dotnet/project-system#199

@livarcocc
Copy link
Contributor

Project A -> Project B -> Project C, this is not supported by the SDK because it does not handle transitive dependencies.
We need to add Project C as a ProjectDependency of Project A.

@nguerrera
Copy link
Contributor

nguerrera commented Nov 18, 2016

@livarcocc Was https://github.com/dotnet/cli/issues/4414#issuecomment-253925947 (set private assets on promoted refs) addressed with the fix? I'm not seeing it. cc @joelverhagen

@nguerrera
Copy link
Contributor

If not and pack is generating too many dependencies, we can infer private assets from FromP2P in the SDK to make things retroactively work on already migrated projects.

@livarcocc
Copy link
Contributor

@nguerrera No, it was not added. And that is a mistake. It should have been. I can add this going forward, if necessary. But if you can handle it using the FromP2P, that would be good too.

@msftgits msftgits transferred this issue from dotnet/cli Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants