Optimize dependency context memory usage #2264

pakrym · 2016-04-04T22:26:40Z

Pool strings
Do not hold onto DependencyContextJsonReader in DependencyContextLoader
Use same reader with same string pool to load multiple contexts in case of portable app.

Brings DependencyContext size in ASP.NET app to ~250kb.

/cc @davidfowl

This change is

krwq · 2016-04-04T22:42:43Z

What's the previous DependencyContext size?

pakrym · 2016-04-04T22:43:16Z

~550kb

pakrym · 2016-04-04T23:05:46Z

@dotnet-bot Test CentOS7.1 x64 Debug Build Please

src/Microsoft.Extensions.DependencyModel/DependencyContextJsonReader.cs

@@ -12,6 +12,8 @@ namespace Microsoft.Extensions.DependencyModel
 {
    public class DependencyContextJsonReader : IDependencyContextReader
    {
+        private readonly IDictionary<string, string> _stringPool = new Dictionary<string, string>();


pakrym · 2016-04-05T19:10:50Z

@dotnet-bot test Windows_NT x86 Debug Build please

pakrym · 2016-04-28T22:48:42Z

@dotnet-bot test Windows_NT x86 Debug Build please
@dotnet-bot test CentOS7.1 x64 Debug Build please

eerhardt · 2016-05-11T18:10:18Z

@pakrym - this has conflicts. Are we still interested in taking this change? If so, can you resolve the conflicts? If not, please close.

pakrym · 2016-05-11T18:12:35Z

Are you taking preview2 changes already?

eerhardt · 2016-05-11T18:14:14Z

As of last night rel/1.0.0 is open for business for preview2. We have branched preview1 to rel/1.0.0-preview1.

pakrym · 2016-05-11T18:15:24Z

I'll rebase this change then

pakrym · 2016-05-16T17:40:12Z

/cc @anurse

src/Microsoft.Extensions.DependencyModel/DependencyContextLoader.cs


        public DependencyContextLoader() : this(
            DependencyContextPaths.Current.Application,
            DependencyContextPaths.Current.SharedRuntime,
            FileSystemWrapper.Default,
-            new DependencyContextJsonReader())
+            () => new DependencyContextJsonReader())
        {
        }

        internal DependencyContextLoader(


eerhardt · 2016-05-16T17:47:46Z

Enable x-plat net46 build using framework reference assemblies from NuGet

dnfclas added the cla-already-signed label Apr 4, 2016

leecow added the in progress label Apr 4, 2016

eerhardt reviewed Apr 4, 2016
View reviewed changes

pakrym force-pushed the pakrym/dc-memory branch from b04e44c to 5be3b80 Compare April 13, 2016 18:43

pakrym force-pushed the pakrym/dc-memory branch from 5be3b80 to bd467a7 Compare April 28, 2016 18:52

pakrym force-pushed the pakrym/dc-memory branch from bd467a7 to 04926a4 Compare May 11, 2016 23:14

Optimize dependency context memory usage

43c638e

pakrym force-pushed the pakrym/dc-memory branch from 04926a4 to 43c638e Compare May 11, 2016 23:14

eerhardt reviewed May 16, 2016
View reviewed changes

pakrym merged commit 07b785c into rel/1.0.0 May 16, 2016

leecow removed the in progress label May 16, 2016

eerhardt deleted the pakrym/dc-memory branch May 16, 2016 17:57

wli3 pushed a commit to wli3/cli that referenced this pull request Nov 14, 2018

Merge pull request dotnet#2264 from nguerrera/x-plat-net46

c34d2d0

Enable x-plat net46 build using framework reference assemblies from NuGet

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Optimize dependency context memory usage #2264

Optimize dependency context memory usage #2264

pakrym commented Apr 4, 2016

krwq commented Apr 4, 2016

pakrym commented Apr 4, 2016

pakrym commented Apr 4, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

pakrym commented Apr 5, 2016

pakrym commented Apr 28, 2016 •

edited by TheRealPiotrP

Loading

eerhardt commented May 11, 2016

pakrym commented May 11, 2016

eerhardt commented May 11, 2016

pakrym commented May 11, 2016

pakrym commented May 16, 2016

This comment was marked as spam.

This comment was marked as spam.

eerhardt commented May 16, 2016

Optimize dependency context memory usage #2264

Optimize dependency context memory usage #2264

Conversation

pakrym commented Apr 4, 2016

krwq commented Apr 4, 2016

pakrym commented Apr 4, 2016

pakrym commented Apr 4, 2016

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

pakrym commented Apr 5, 2016

pakrym commented Apr 28, 2016 • edited by TheRealPiotrP Loading

eerhardt commented May 11, 2016

pakrym commented May 11, 2016

eerhardt commented May 11, 2016

pakrym commented May 11, 2016

pakrym commented May 16, 2016

This comment was marked as spam.

This comment was marked as spam.

eerhardt commented May 16, 2016

pakrym commented Apr 28, 2016 •

edited by TheRealPiotrP

Loading