Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Bug fixes #4810

Merged
merged 6 commits into from
Nov 24, 2016
Merged

Bug fixes #4810

merged 6 commits into from
Nov 24, 2016

Conversation

Faizan2304
Copy link

@Faizan2304 Faizan2304 commented Nov 22, 2016

@TheRealPiotrP
Copy link

Wonderful! We have a build break we need to resolve, but I can't wait to merge this!

@MattGertz It'd be great to get your approval preemptively!

-Added test to cover trx logger scenario.
@livarcocc
Copy link

@dotnet-bot Test this please

…nonzero if test fails. In multi TFM scenario if test fails it termates the whole process as dotnet test is returning 1. As a fix of this we should continue if some test fails for next TFM
@livarcocc
Copy link

@dotnet-bot Test Ubuntu x64 Release Build

@livarcocc
Copy link

@MattGertz and @srivatsn for approval.

@livarcocc
Copy link

@MattGertz and @srivatsn for approval.

@TheRealPiotrP
Copy link

@dotnet-bot test Windows_NT x86 Debug Build please.

@TheRealPiotrP
Copy link

@dotnet-bot test Ubuntu x64 Release Build please.

@TheRealPiotrP
Copy link

@dotnet-bot test Fedora23 x64 Debug Build please.

@TheRealPiotrP
Copy link

can't wait to click merge... :)

@Faizan2304
Copy link
Author

@piotrpMSFT: Now you can merge.. :)

@TheRealPiotrP TheRealPiotrP merged commit eb8e0cf into dotnet:rel/1.0.0 Nov 24, 2016
@TheRealPiotrP
Copy link

🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants