-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix Linux build. cli package for testing is based on 1.x which does not work. #7387
Fix Linux build. cli package for testing is based on 1.x which does not work. #7387
Conversation
…ot work. ...unless you are using Ubuntu 14.04 or 16.04. Note that it is not just a test blocker, it is a build blocker.
@atsushieno, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for testing back compact
Hi @atsushieno do you mind explain the detail why it is a blocker? And the error message? We are running the build for different distro in docker as part of our CI. |
This is what actually happens if you run build.sh on Ubuntu 17.04: https://app.wercker.com/atsushieno/mono-dotnetcore-docker/runs/build/598a773d33541e0001fac283?step=598a7c839529cc00012342a8 It is an automated build from Docker image which is completely clean and based on Ubuntu 17.04. Everything is described here: https://github.com/atsushieno/mono-dotnetcore-docker/tree/dotnetcli (my github repository to prove clean build failures, this branch is tailored for this exact build issue) |
@@ -164,7 +164,7 @@ if [ $EXIT_CODE != 0 ]; then | |||
fi | |||
|
|||
# Install a project.json based CLI for use by tests | |||
(set -x ; "$REPOROOT/scripts/obtain/dotnet-install.sh" --channel "master" --install-dir "$DOTNET_INSTALL_DIR_PJ" --architecture "$ARCHITECTURE" --version "1.0.0-preview2-1-003177") | |||
(set -x ; "$REPOROOT/scripts/obtain/dotnet-install.sh" --channel "master" --install-dir "$DOTNET_INSTALL_DIR_PJ" --architecture "$ARCHITECTURE" --version "2.1.0-preview1-007012") |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Closing because #7522 in progress will fix the issue the correct way. Thanks, @atsushieno for alerting us to this. |
awesome, looking forward to the fix :-) |
...unless you are using Ubuntu 14.04 or 16.04.
Note that it is not just a test blocker, it is a build blocker.