Update CoreSetup to preview1-25719-04 (master)

[dotnet-bot]

/cc @dotnet/dotnet-cli

[eerhardt]

/cc @ahsonkhan

[eerhardt]

FYI - @dotnet/dotnet-cli update-dependencies seems to be working again in master.

[ahsonkhan]

@eerhardt, awesome. Tyvm for the update!

[livarcocc]

@KevinRansom the failing tests are all F#, can you take a first look at this?

[KevinRansom]

@livarcocc @eerhardt on it.

[eerhardt]

@KevinRansom - any update?

[ahsonkhan]

@eerhardt, @KevinRansom, any eta on this update?

[janvorli]

I've tried to do the binary search and the problem came in between:
2.1.0-preview2-25625-01 - commit #dc2ffcdff2fb19e4b252cec3bc6672400a375c1e
2.1.0-preview2-25625-02 - commit #41a2b788cb77668d397e372df40c5215bf61bfa7

But it doesn't change anything in my and @briansull's lists on the gist, since as you can see, the 2.1.0-preview2-25625-01 and the previously known last good 2.1.0-preview2-25616-02 were both built from the same commit.

[eerhardt]

Using 2.1.0-preview2-25625-01 I captured the disassembly for the loop that I captured above. You can compare it against the brokenDisassembly.txt link above.

Here is the working disassembly from the previous build:

previousWorksDisassembly.txt

[KevinRansom]

Adding @dsyme

[JosephTremoulet]

PR for JIT fix into CoreCLR is up at dotnet/coreclr#13957.

[ahsonkhan]

Does <CLI_SharedFrameworkVersion>2.1.0-preview1-25714-02</CLI_SharedFrameworkVersion> have @JosephTremoulet's JIT fix? F# tests are still failing.

[eerhardt]

No it doesn't.
We just got a CoreCLR build out with @JosephTremoulet's change an hour ago. I just merged that into core-setup dotnet/core-setup#3222.

So the next build of core-setup should have the fix.

[janvorli]

All Unix builds are segfaulting in crossgen with the latest coresetup version. I've reproed it locally and it seems to be a codegen issue - see https://github.com/dotnet/coreclr/issues/13942

[livarcocc]

@eerhardt @janvorli any updates on this?

[eerhardt]

Official builds have been broken for all dotnet/core* repos since yesterday. No way of getting a new core-setup build out right now. The current one has been running for 85 minutes and appears to be hung.

[eerhardt]

But once the official builds are unblocked, I believed that last remaining blocking fix is in core-setup.

[ahsonkhan]

But once the official builds are unblocked, I believed that last remaining blocking fix is in core-setup.

Builds are unblocked & CI is green. Can we merge the PR?