Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Generate Microsoft.NETCoreSdk.BundledCliTools.props #8845

Merged
merged 1 commit into from
Mar 22, 2018
Merged

Generate Microsoft.NETCoreSdk.BundledCliTools.props #8845

merged 1 commit into from
Mar 22, 2018

Conversation

natemcmaster
Copy link

Companion PR to dotnet/sdk#2064. This generates Microsoft.NETCoreSdk.BundledCliTools.props so the SDK can issue warnings about obsolete DotNetCliToolReference packages.

FYI @bricelam - this doesn't include dotnet-ef yet.

Example generated content:

<!--
***********************************************************************************************
Microsoft.NETCoreSdk.BundledCliTools.props

WARNING:  DO NOT MODIFY this file unless you are knowledgeable about MSBuild and have
          created a backup copy.  Incorrect changes to this file will make it
          impossible to load or build your projects from the command-line or the IDE.

Copyright (c) .NET Foundation. All rights reserved.
***********************************************************************************************
-->
<Project>
  <ItemGroup>
    <BundledDotNetCliToolReference Include="Microsoft.Extensions.Caching.SqlConfig.Tools" />
    <BundledDotNetCliToolReference Include="Microsoft.Extensions.SecretManager.Tools" />
    <BundledDotNetCliToolReference Include="Microsoft.DotNet.Watcher.Tools" />
  </ItemGroup>
</Project>

@natemcmaster
Copy link
Author

By the way, if I want to get this into preview2, should I change the branch this PR targets?

@livarcocc
Copy link

release/2.1.3xx will guarantee you are in preview2. master will depend on RIes.

<BundledDotnetTools Include="dotnet-sql-cache" Version="$(AspNetCoreVersion)" />
<BundledDotnetTools Include="dotnet-user-secrets" Version="$(AspNetCoreVersion)" />
<BundledDotnetTools Include="dotnet-watch" Version="$(AspNetCoreVersion)" />
<BundledDotnetTools Include="dotnet-sql-cache" Version="$(AspNetCoreVersion)" ObsoletesCliTool="Microsoft.Extensions.Caching.SqlConfig.Tools" />

This comment was marked as spam.

This comment was marked as spam.

@natemcmaster natemcmaster changed the base branch from master to release/2.1.3xx March 19, 2018 21:29
@natemcmaster
Copy link
Author

Ok. I rebased this onto release/2.1.3xx

@natemcmaster
Copy link
Author

Test failure on CentOS "Microsoft.DotNet.Tests.GivenAProjectToolsCommandResolver.ItAddsFxVersionAsAParamWhenTheToolHasThePrefercliruntimeFile"

This seems to be unrelated to my change. Is this a known test issue?

@natemcmaster
Copy link
Author

@dotnet-bot test CentOS7.1 x64 Debug Build

@natemcmaster
Copy link
Author

Ping for final review. All CI tests pass now.

@livarcocc livarcocc added this to the 2.1.3xx milestone Mar 22, 2018
@livarcocc livarcocc merged commit 4298cde into dotnet:release/2.1.3xx Mar 22, 2018
@natemcmaster natemcmaster deleted the obsolete-cli-ref branch March 22, 2018 20:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants