Fix optdata restore functionality #11935
Conversation
dir.props
Outdated
| @@ -21,6 +21,13 @@ | |||
| <RoslynPackageName>Microsoft.Net.ToolsetCompilers</RoslynPackageName> | |||
| </PropertyGroup> | |||
|
|
|||
| <!-- Profile-based optimization data package versions --> | |||
| <PropertyGroup> | |||
| <!-- TODO: Fill in with actual versions from the right branches --> | |||
There was a problem hiding this comment.
FYI: We are generating counts packages today and I plan to resolve this TODO before merging. If that gets missed, nothing breaks, and it's a trivial follow-up PR to update this.
|
@wtgodbe @adiaaida PTAL |
|
Please email shiproom to bring this to 2.0.0, assuming this is merged into master. |
|
@gkhanna79 Definitely, will do. |
|
@dotnet-bot test windows_nt x86 perf |
|
@dotnet-bot test windows_nt x64 perf |
|
@dotnet-bot test Ubuntu14.04 perf |
|
@dotnet-bot test Ubuntu14.04 perf |
|
@jorive PTAL |
|
LGTM, but do we want to have an option to skip using optdata? Like if we wanted to do a perf comparison of pgo vs non-pgo? |
|
@adiaaida thanks for the review! You're right; we do still have that functionality, |
Bring back optdata restore functionality following the move to 2.0 BuildTools and csproj-based CLI. Disable a harmless warning that broke the Linux build when consuming PGO counts due to -Werr.
Fix #11796 for master. We will need to get this ported to release/2.0.0 as well.