This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Do not compute the IDF for all blocks in advance #15146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikedn
changed the title
InsertsPhiFunctions visits each block only once so there's no need to compute and store the IDFs for all blocks in advance. The IDF of a given block can be computed when the block is visited and discarded after that. This way a single BlkVector can be reused for all blocks.
mikedn
commented
Nov 23, 2017
| @@ -439,10 +439,7 @@ void vector<T, Allocator>::clear() | |||
| { | |||
| m_pArray[i].~T(); | |||
| } | |||
| m_allocator.deallocate(m_pArray, m_nCapacity); | |||
| m_pArray = NULL; | |||
There was a problem hiding this comment.
vector::clear() is not required to release the memory. Doing this prevents memory reuse.
|
cc @dotnet/jit-contrib |
|
@dotnet-bot test CentOS7.1 x64 Checked Innerloop Build and Test |
|
LGTM, thank you. |
|
NIce! Not only does this save memory, it improves readability as well, especially with the addition of the header comments. |
CarolEidt
approved these changes
Mar 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InsertsPhiFunctionsvisits each block only once so there's no need tocompute and store the IDFs for all blocks in advance. The IDF of a given
block can be computed when the block is visited and discarded after
that. This way a single
BlkVectorcan be reused for all blocks.This saves 12% CMK_SSA memory.
MemStats diff: https://gist.github.com/mikedn/d5fb13e06f181f29de420510fd07d7d9
No jit diffs.