Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Add optional integer offset to OwnedMemory Pin #15410

Merged
merged 1 commit into from
Dec 8, 2017
Merged

Add optional integer offset to OwnedMemory Pin #15410

merged 1 commit into from
Dec 8, 2017

Conversation

ahsonkhan
Copy link

@ahsonkhan ahsonkhan mentioned this pull request Dec 7, 2017
Merged
@ahsonkhan
Copy link
Author

@dotnet-bot test Ubuntu x64 Checked Innerloop Build and Test

Any ideas why this test failed?
https://ci.dot.net/job/dotnet_coreclr/job/master/job/checked_ubuntu_tst_prtest/11681/consoleFull#-8536224876a086b3e-df04-41d2-bc4d-43e8f9406d07

20:45:02 FAILED   - GC/Scenarios/LeakWheel/leakwheel/leakwheel.sh
20:45:02                BEGIN EXECUTION
20:45:02                /mnt/j/workspace/dotnet_coreclr/master/checked_ubuntu_tst_prtest/bin/tests/Windows_NT.x64.Checked/Tests/coreoverlay/corerun leakwheel.exe
20:45:02                Repro with these values:
20:45:02                iMem= 10 MB, iIter= 1500000, iTable=500 iSeed=924454866
20:45:02                After Delete and GCed all Objects: 279792
20:45:02                After Delete and GCed all Objects: 10483888
20:45:02                After Delete and GCed all Objects: 279744
20:45:02                After Delete and GCed all Objects: 10486496
20:45:02                After Delete and GCed all Objects: 10486496
...
20:45:02                After Delete and GCed all Objects: 279768
20:45:02                When test finished: 5086568
20:45:02                Created VarAry objects: 150321 Finalized VarAry Objects: 149942
20:45:02                Created BitArray objects: 150196 Finalized BitArray Objects: 149942
20:45:02                Created small objects: 300134 Finalized small Objects: 299510
20:45:02                Created BinaryTree objects: 149928 Finalized BinaryTree Objects: 149531
20:45:02                Created Thread objects: 0 Finalized Thread Objects: 0
20:45:02                Test Failed!
20:45:02                Expected: 100
20:45:02                Actual: 1
20:45:02                END EXECUTION - FAILED

@jkotas jkotas merged commit 8931cfa into dotnet:master Dec 8, 2017
@ahsonkhan ahsonkhan deleted the PinOffset branch December 9, 2017 00:16
This was referenced Dec 9, 2017
Closed
Closed
dotnet-bot pushed a commit to dotnet/corert that referenced this pull request Dec 9, 2017
@ahsonkhan @dotnet-bot
Add optional integer offset to OwnedMemory Pin (dotnet/coreclr#15410)
6b58c94 
Signed-off-by: dotnet-bot <[email protected]>
jkotas pushed a commit to dotnet/corert that referenced this pull request Dec 9, 2017
@ahsonkhan @jkotas
Add optional integer offset to OwnedMemory Pin (dotnet/coreclr#15410)
c90efa5 
Signed-off-by: dotnet-bot <[email protected]>
jashook pushed a commit to jashook/coreclr that referenced this pull request Dec 12, 2017
@ahsonkhan
Add optional integer offset to OwnedMemory Pin (dotnet#15410)
f037cfe
jkotas added a commit to jkotas/coreclr that referenced this pull request Dec 14, 2017
@jkotas
Revert "Add optional integer offset to OwnedMemory Pin (dotnet#15410)"
d91c7bb 
This reverts commit 8931cfa.
@ahsonkhan ahsonkhan mentioned this pull request Dec 14, 2017
Closed
jkotas added a commit that referenced this pull request Dec 14, 2017
@jkotas
Merge pull request #15516 from jkotas/revert
7b55151 
Revert "Add optional integer offset to OwnedMemory Pin (#15410)"
ahsonkhan added a commit to ahsonkhan/coreclr that referenced this pull request Dec 14, 2017
@ahsonkhan
Isolating the ref readonly indexer change only to CoreCLR for now.
7c18942 
Reverting the change to Enumerator Current for now

Fix file formatting

Enable Alpine CI (dotnet#15502)

* Enable Alpine CI

This enables Alpine CI leg on every PR using the pipelines.

compare type size instead of var_types

get rid of TYP_CHAR

Adding support for Acosh, Asinh, Atanh, and Cbrt to Math and MathF

Updating the PAL layer to support acosh, asinh, atanh, and cbrt

Adding some PAL tests for acosh, asinh, atanh, and cbrt

Adding valuenum support for acosh, asinh, atanh, and cbrt

Lsra Documentation

Update LinearScan section of ryujit-overview.md, and add lsra-detail.md

Refactor Unsafe.cs to get it more in sync with CoreRT. (dotnet#15510)

* Refactor Unsafe.cs to get it more in sync with CoreRT.

* Format the document.

* Unifying the copies of Unsafe using ifdefs

* Change exception thrown to PlatformNotSupportedException

* Addressing PR feedback and moving Unsafe to shared.

* Addressing PR feedback

* Addressing PR review - adding intrinsic attribute

Update CoreClr, CoreFx to preview1-26014-01, preview1-26013-12, respectively (dotnet#15513)

Revert "Add optional integer offset to OwnedMemory Pin (dotnet#15410)"

This reverts commit 8931cfa.

Get rid of old -altjitcrossgen argument now that CI has been updated

Merge pull request dotnet/corert#5109 from dotnet/nmirror (dotnet#15518)

Merge nmirror to master

Signed-off-by: dotnet-bot <[email protected]>

Revert " Revert "[Local GC] Move knowledge of overlapped I/O objects to the EE through four callbacks (dotnet#14982)""

Fix typo `_TARGET_ARM` to `_TARGET_ARM_`. This happens mostly in comments except lsra.cpp.

Update CoreClr, CoreFx, PgoData to preview1-26014-04, preview1-26014-03, master-20171214-0043, respectively (dotnet#15520)
ahsonkhan added a commit to ahsonkhan/coreclr that referenced this pull request Dec 14, 2017
@ahsonkhan
Isolating the ref readonly indexer change only to CoreCLR for now.
8bc3964 
Reverting the change to Enumerator Current for now

Fix file formatting

Enable Alpine CI (dotnet#15502)

* Enable Alpine CI

This enables Alpine CI leg on every PR using the pipelines.

compare type size instead of var_types

get rid of TYP_CHAR

Adding support for Acosh, Asinh, Atanh, and Cbrt to Math and MathF

Updating the PAL layer to support acosh, asinh, atanh, and cbrt

Adding some PAL tests for acosh, asinh, atanh, and cbrt

Adding valuenum support for acosh, asinh, atanh, and cbrt

Lsra Documentation

Update LinearScan section of ryujit-overview.md, and add lsra-detail.md

Refactor Unsafe.cs to get it more in sync with CoreRT. (dotnet#15510)

* Refactor Unsafe.cs to get it more in sync with CoreRT.

* Format the document.

* Unifying the copies of Unsafe using ifdefs

* Change exception thrown to PlatformNotSupportedException

* Addressing PR feedback and moving Unsafe to shared.

* Addressing PR feedback

* Addressing PR review - adding intrinsic attribute

Update CoreClr, CoreFx to preview1-26014-01, preview1-26013-12, respectively (dotnet#15513)

Revert "Add optional integer offset to OwnedMemory Pin (dotnet#15410)"

This reverts commit 8931cfa.

Get rid of old -altjitcrossgen argument now that CI has been updated

Merge pull request dotnet/corert#5109 from dotnet/nmirror (dotnet#15518)

Merge nmirror to master

Signed-off-by: dotnet-bot <[email protected]>

Revert " Revert "[Local GC] Move knowledge of overlapped I/O objects to the EE through four callbacks (dotnet#14982)""

Fix typo `_TARGET_ARM` to `_TARGET_ARM_`. This happens mostly in comments except lsra.cpp.

Update CoreClr, CoreFx, PgoData to preview1-26014-04, preview1-26014-03, master-20171214-0043, respectively (dotnet#15520)
ahsonkhan added a commit that referenced this pull request Dec 15, 2017
@ahsonkhan
Change ReadOnlySpan indexer to return ref readonly (#14727)
1ec4888 
* Change ReadOnlySpan indexer to return ref readonly.

Update JIT to handle changes to ReadOnlySpan indexer

Resolving merge conflict and fixing jit importer

Update ReadOnlySpan Enumerator Current to use indexer.

Removing readonly keyword.

* Temporarily disabling Span perf and other tests that use ReadOnlySpan

* Isolating the ref readonly indexer change only to CoreCLR for now.

Reverting the change to Enumerator Current for now

Fix file formatting

Enable Alpine CI (#15502)

* Enable Alpine CI

This enables Alpine CI leg on every PR using the pipelines.

compare type size instead of var_types

get rid of TYP_CHAR

Adding support for Acosh, Asinh, Atanh, and Cbrt to Math and MathF

Updating the PAL layer to support acosh, asinh, atanh, and cbrt

Adding some PAL tests for acosh, asinh, atanh, and cbrt

Adding valuenum support for acosh, asinh, atanh, and cbrt

Lsra Documentation

Update LinearScan section of ryujit-overview.md, and add lsra-detail.md

Refactor Unsafe.cs to get it more in sync with CoreRT. (#15510)

* Refactor Unsafe.cs to get it more in sync with CoreRT.

* Format the document.

* Unifying the copies of Unsafe using ifdefs

* Change exception thrown to PlatformNotSupportedException

* Addressing PR feedback and moving Unsafe to shared.

* Addressing PR feedback

* Addressing PR review - adding intrinsic attribute

Update CoreClr, CoreFx to preview1-26014-01, preview1-26013-12, respectively (#15513)

Revert "Add optional integer offset to OwnedMemory Pin (#15410)"

This reverts commit 8931cfa.

Get rid of old -altjitcrossgen argument now that CI has been updated

Merge pull request dotnet/corert#5109 from dotnet/nmirror (#15518)

Merge nmirror to master

Signed-off-by: dotnet-bot <[email protected]>

Revert " Revert "[Local GC] Move knowledge of overlapped I/O objects to the EE through four callbacks (#14982)""

Fix typo `_TARGET_ARM` to `_TARGET_ARM_`. This happens mostly in comments except lsra.cpp.

Update CoreClr, CoreFx, PgoData to preview1-26014-04, preview1-26014-03, master-20171214-0043, respectively (#15520)

* Disabling a test that uses ReadOnlySpan indexer

* Temporarily disabling the superpmi test and fixing nit

* Remove debug statements.
@ahsonkhan ahsonkhan restored the PinOffset branch December 15, 2017 21:45
dotnet-bot pushed a commit to dotnet/corefx that referenced this pull request Jan 13, 2018
@ahsonkhan @dotnet-bot
Add optional integer offset to OwnedMemory Pin (dotnet/coreclr#15410)
f697474 
Signed-off-by: dotnet-bot-corefx-mirror <[email protected]>
dotnet-bot pushed a commit to dotnet/corefx that referenced this pull request Jan 13, 2018
@ahsonkhan @dotnet-bot
Add optional integer offset to OwnedMemory Pin (dotnet/coreclr#15410)
5e504f2 
Signed-off-by: dotnet-bot-corefx-mirror <[email protected]>
safern pushed a commit to dotnet/corefx that referenced this pull request Jan 16, 2018
@ahsonkhan @safern
Add optional integer offset to OwnedMemory Pin (dotnet/coreclr#15410)
1f9f117 
Signed-off-by: dotnet-bot-corefx-mirror <[email protected]>
safern pushed a commit to dotnet/corefx that referenced this pull request Jan 16, 2018
@ahsonkhan @safern
Add optional integer offset to OwnedMemory Pin (dotnet/coreclr#15410)
f4a9b19 
Signed-off-by: dotnet-bot-corefx-mirror <[email protected]>
@ahsonkhan ahsonkhan mentioned this pull request Jan 20, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahsonkhan @jkotas