This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
[WIP] Tail call stress needs to check more conditions #22189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AILCALL (as it was before)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix https://github.com/dotnet/coreclr/issues/11408 (and as a result of the aggressive tail call stressing https://github.com/dotnet/coreclr/issues/17584 also)
The idea is to move stress tail calls out of explicit tail call category and do hazard checks for the former (similar to what it's done for implicit tail calls).
@dotnet/jit-contrib Does anyone have any suggestions how to validate that we are not loosing TailCallStress power due to adding those checks?