This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Enabling execution of Perflab perf tests #4100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Also, @dsgouda, please make sure to squash your commits. |
wateret
added a commit
to wateret/coreclr
that referenced
this pull request
Jul 25, 2017
Passing double arg regs via `r0:r1` or `r2:r3`, each RefPosition's RegMask should have only one exact register so the candidate register can be fixed. e.g.) ``` <RefPosition dotnet#4099 @2625 RefTypeUse <Ivl:1237> BB35 regmask=[r0-r1] last> <RefPosition dotnet#4100 @2625 RefTypeUse <Ivl:1238> BB35 regmask=[r0-r1] last> ``` to be: ``` <RefPosition dotnet#4099 @2625 RefTypeUse <Ivl:1237> BB35 regmask=[r0] last fixed> <RefPosition dotnet#4100 @2625 RefTypeUse <Ivl:1238> BB35 regmask=[r1] last fixed> ``` Fix #12994
wateret
added a commit
to wateret/coreclr
that referenced
this pull request
Aug 2, 2017
Passing double arg regs via `r0:r1` or `r2:r3`, each RefPosition's RegMask should have only one exact register so the candidate register can be fixed. e.g.) ``` <RefPosition dotnet#4099 @2625 RefTypeUse <Ivl:1237> BB35 regmask=[r0-r1] last> <RefPosition dotnet#4100 @2625 RefTypeUse <Ivl:1238> BB35 regmask=[r0-r1] last> ``` to be: ``` <RefPosition dotnet#4099 @2625 RefTypeUse <Ivl:1237> BB35 regmask=[r0] last fixed> <RefPosition dotnet#4100 @2625 RefTypeUse <Ivl:1238> BB35 regmask=[r1] last fixed> ``` Fix #12994
wateret
added a commit
to wateret/coreclr
that referenced
this pull request
Aug 7, 2017
Passing double arg regs via `r0:r1` or `r2:r3`, each RefPosition's RegMask should have only one exact register so the candidate register can be fixed. e.g.) ``` <RefPosition dotnet#4099 @2625 RefTypeUse <Ivl:1237> BB35 regmask=[r0-r1] last> <RefPosition dotnet#4100 @2625 RefTypeUse <Ivl:1238> BB35 regmask=[r0-r1] last> ``` to be: ``` <RefPosition dotnet#4099 @2625 RefTypeUse <Ivl:1237> BB35 regmask=[r0] last fixed> <RefPosition dotnet#4100 @2625 RefTypeUse <Ivl:1238> BB35 regmask=[r1] last fixed> ``` Fix #12994
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding project dependencies to perflab so that AssemblyList.txt generated will contain all the dependencies to actually run the tests on the end machine
@lt72 @brianrob