Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Add String.Join overloads accepting a char separator #7942

Merged
merged 12 commits into from
Nov 23, 2016
Merged

Add String.Join overloads accepting a char separator #7942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0439b29
Add String.Join overloads that accept char separators
jamesqo Nov 1, 2016
e9923c7
Add new members to model.xml
jamesqo Nov 1, 2016
b1a33d1
Code sharing for generic Join overloads
jamesqo Nov 2, 2016
12ec865
Don't nullref if the separator is null
jamesqo Nov 3, 2016
edaed6f
Code sharing for Join accepting a string[],int,int
jamesqo Nov 3, 2016
8ded066
UnSafeCharBuffer is no longer being used, so delete it
jamesqo Nov 3, 2016
f9e57c2
Use nameof
jamesqo Nov 3, 2016
91ee75d
Respond to PR feedback
jamesqo Nov 3, 2016
5e9f536
Typo
jamesqo Nov 3, 2016
c5c9f55
Format IEnumerable<string> overload
jamesqo Nov 3, 2016
c60c141
Format some more Join overloads
jamesqo Nov 3, 2016
6a80496
Share code for remaining Join overload.
jamesqo Nov 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/mscorlib/model.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7394,6 +7394,10 @@
<Member Name="IsNormalized(System.Text.NormalizationForm)" />
<Member Name="IsNullOrEmpty(System.String)" />
<Member Name="IsNullOrWhiteSpace(System.String)" />
<Member Name="Join(System.Char,System.Object[])" />
<Member Name="Join&lt;T&gt;(System.Char,System.Collections.Generic.IEnumerable&lt;T&gt;)" />
<Member Name="Join(System.Char,System.String[])" />
<Member Name="Join(System.Char,System.String[],System.Int32,System.Int32)" />
<Member Name="Join(System.String,System.Object[])" />
<Member Name="Join&lt;T&gt;(System.String,System.Collections.Generic.IEnumerable&lt;T&gt;)" />
<Member Name="Join(System.String,System.Collections.Generic.IEnumerable&lt;System.String&gt;)" />
Expand Down
1 change: 0 additions & 1 deletion src/mscorlib/mscorlib.shared.sources.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,6 @@
<SystemSources Include="$(BclSourcesRoot)\System\UnitySerializationHolder.cs" />
<SystemSources Include="$(BclSourcesRoot)\System\UnhandledExceptionEventArgs.cs" />
<SystemSources Include="$(BclSourcesRoot)\System\UnhandledExceptionEventHandler.cs" />
<SystemSources Include="$(BclSourcesRoot)\System\UnSafeCharBuffer.cs" />
<SystemSources Include="$(BclSourcesRoot)\System\ValueType.cs" />
<SystemSources Include="$(BclSourcesRoot)\System\Version.cs" />
<SystemSources Include="$(BclSourcesRoot)\System\Void.cs" />
Expand Down
Loading