This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
[x86/Linux] Fix unsupported architecture in seh-unwind.cpp #8262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know much about unwind so please guide me if anything needs to be fixed in this patch. |
janvorli
reviewed
Nov 23, 2016
| @@ -196,6 +212,9 @@ static void GetContextPointers(unw_cursor_t *cursor, unw_context_t *unwContext, | |||
| GetContextPointer(cursor, unwContext, UNW_X86_64_R13, &contextPointers->R13); | |||
| GetContextPointer(cursor, unwContext, UNW_X86_64_R14, &contextPointers->R14); | |||
| GetContextPointer(cursor, unwContext, UNW_X86_64_R15, &contextPointers->R15); | |||
| #elif defined(_X86_) | |||
| GetContextPointer(cursor, unwContext, UNW_X86_EBP, &contextPointers->Ebp); | |||
janvorli
reviewed
Nov 23, 2016
| @@ -122,6 +128,11 @@ static void WinContextToUnwindCursor(CONTEXT *winContext, unw_cursor_t *cursor) | |||
| unw_set_reg(cursor, UNW_X86_64_R13, winContext->R13); | |||
| unw_set_reg(cursor, UNW_X86_64_R14, winContext->R14); | |||
| unw_set_reg(cursor, UNW_X86_64_R15, winContext->R15); | |||
| #elif defined(_X86_) | |||
| unw_set_reg(cursor, UNW_REG_IP, winContext->Eip); | |||
There was a problem hiding this comment.
I am sorry I have not noticed this before, but we need the Rsi and Rdi here as well (and the same in the UnwindContextToWinContext below)
There was a problem hiding this comment.
Thank you :) It's OK to change again. This is a huge place.
Fix compile error for x86/Linux - add ASSIGN_UNWIND_REGS in seh-unwind.cpp for x86 - add CONTEXT_EXCEPTION_ACTIVE in pal.h for x86 - add CONTEXT_XSTATE in pal.h for x86
|
Done adding |
|
@dotnet-bot test Windows_NT x86 compatjit Checked Build and Test please |
99 tasks
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…reclr#8262) Fix compile error for x86/Linux - add ASSIGN_UNWIND_REGS in seh-unwind.cpp for x86 - add CONTEXT_EXCEPTION_ACTIVE in pal.h for x86 - add CONTEXT_XSTATE in pal.h for x86 Commit migrated from dotnet/coreclr@f85bf7c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix compile error for x86/Linux