This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Supports to build PAL tests under x86/Linux #8292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @seanshpark |
|
@dotnet-bot test Windows_NT x64 Debug Build and Test please |
seanshpark
reviewed
Nov 24, 2016
| @@ -23,7 +27,7 @@ elseif(PAL_CMAKE_PLATFORM_ARCH_ARM64) | |||
| add_definitions(-DBIT64=1) | |||
| add_definitions(-D_WIN64=1) | |||
| else() | |||
| message(FATAL_ERROR "Only ARM, ARM64 and AMD64 is supported") | |||
| message(FATAL_ERROR "Only ARM, ARM64, I386, and AMD64 is supported") | |||
There was a problem hiding this comment.
I'm curious what we should call this, I386 or X86.
There was a problem hiding this comment.
I'm also confused. x86 and x64 are used in build.sh, but I386 and AMD64 are used in CMakeLists.txt.
Here I followed the convention in CMakeLists.txt.
There was a problem hiding this comment.
We already use CLR_CMAKE_TARGET_ARCH_I386 in the CMakeLists.txt, so this matches the change.
|
Please ignore the x86 compatjit and x86 legacy_backend jobs if they fail. They have been removed from future PRs. |
99 tasks
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.