This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
[x86/Linux] Fix error variable 'td' is uninitialized #8299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
reviewed
Nov 24, 2016
| long double td; | ||
| #else | ||
| double td = 0.0; | ||
| #endif | ||
| __asm fstp td // copy out the double |
There was a problem hiding this comment.
Does this inline assembly compile on Unix? I would expect that this whole block will need #ifdef _MSCVER to differentiate between Windows-style inline assembly and Unix-style inline assembly.
There was a problem hiding this comment.
It seems to compile with clang3.8, which I'm using.
There was a problem hiding this comment.
You can just initialize it unconditionally to 0, even on Windows - no need for ifdef.
There was a problem hiding this comment.
simple test code doesn't seem to compile. I need to check.
There was a problem hiding this comment.
for information, clang simple test code with -fasm-blocks passes compilation.
Fix compile error for x86/Linux - make compiler happy with initialize variable 'td' with 0.0
|
@janvorli , @jkotas , @gkhanna79 , PTAL |
|
@jkotas, could you please look this again? |
|
LGTM |
99 tasks
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…8299) Fix compile error for x86/Linux - make compiler happy with initialize variable 'td' with 0.0 Commit migrated from dotnet/coreclr@e5d9c9f
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix compile error for x86/Linux