Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

[x86/Linux] Fix the mistmatch between gc_thread_stub and GCThreadFunction #8336

Merged
merged 1 commit into from
Nov 29, 2016

Conversation

parjong
Copy link

@parjong parjong commented Nov 29, 2016

This commit fixes the following warning during x86/Linux build:

/home/parjong/projects/dotnet/coreclr/src/gc/gc.cpp:5192:42: error: cannot initialize a parameter of type 'GCThreadFunction' (aka 'void (*)(void *)') with an lvalue of type 'void (void *) __attribute__((stdcall))'
    return GCToOSInterface::CreateThread(gc_thread_stub, this, &affinity);
                                         ^~~~~~~~~~~~~~
/home/parjong/projects/dotnet/coreclr/src/gc/env/gcenv.os.h:153:47: note: passing argument to parameter 'function' here
    static bool CreateThread(GCThreadFunction function, void* param, GCThreadAffinity* affinity);
                                                                           ^

@parjong parjong changed the title Fix the mistmatch between gc_thread_stub and GCThreadFunction [x86/Linux] Fix the mistmatch between gc_thread_stub and GCThreadFunction Nov 29, 2016
@parjong
Copy link
Author

parjong commented Nov 29, 2016

\CC @seanshpark

Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@janvorli
Copy link
Member

cc: @Maoni0, @swgillespie

@janvorli janvorli merged commit 31c5791 into dotnet:master Nov 29, 2016
@parjong parjong deleted the fix/gc_thread_stub_mismatch branch November 29, 2016 22:12
@parjong parjong restored the fix/gc_thread_stub_mismatch branch November 30, 2016 23:14
@parjong parjong deleted the fix/gc_thread_stub_mismatch branch November 30, 2016 23:14
@karelz karelz modified the milestone: 2.0.0 Aug 28, 2017
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants