Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

[x86/Linux] Emit compile error on porting issue when PORTABILITY_CHECK is set #8340

Merged
merged 1 commit into from
Nov 30, 2016

Conversation

parjong
Copy link

@parjong parjong commented Nov 29, 2016

The current implementation of PORTABILITY_WARNING and PORTABILITY_ASSERT emits compile error when TARGET_X86 is defined.

This commit revises this implementation to emit compile error when PORTABILITY_CHECK is defined.

@parjong
Copy link
Author

parjong commented Nov 29, 2016

\CC @seanshpark

@parjong parjong changed the title Emits compile error on porting issue when PORTABILITY_CHECK is set Emit compile error on porting issue when PORTABILITY_CHECK is set Nov 29, 2016
@parjong parjong changed the title Emit compile error on porting issue when PORTABILITY_CHECK is set [x86/Linux] Emit compile error on porting issue when PORTABILITY_CHECK is set Nov 30, 2016
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you!

@janvorli janvorli merged commit a8eebfd into dotnet:master Nov 30, 2016
@parjong parjong deleted the fix/portability_check branch November 30, 2016 23:15
@karelz karelz modified the milestone: 2.0.0 Aug 28, 2017
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants