This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
[x86/Linux] Revise RealCodeHeader and CodeHeader #8344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes #8342.
|
\CC @seanshpark |
parjong
changed the title
jkotas
reviewed
Nov 29, 2016
| SelfType Self(void) | ||
| { | ||
| #ifdef DACCESS_COMPILE | ||
| return (TADDR) this; |
There was a problem hiding this comment.
This cast is not right for DACCESS_COMPILE.
The rules for DACCESS_COMPILE are explained in https://github.com/dotnet/coreclr/blob/master/src/inc/daccess.h#L138, and the whole story is in https://github.com/dotnet/coreclr/blob/master/Documentation/botr/dac-notes.md.
|
As discussed in #8296, it may be better to change strategy and get Linux x86 to compile and work with |
|
Thanks you for comment. I'll try that approach, too. |
|
Let's close this for now and see where we get with !WIN64EXCEPTIONS. |
|
This PR is merged into #8629. |
99 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes #8342.