This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
[x86/Linux] Fix mismatch between sortversioning.h and sortversioning.cpp #8366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
\CC @seanshpark |
|
FWIW, it would interesting to explore (or file a follow up work item) to see if we can remove the need to include sortversioning.cpp and sortversioning.h on *nix entirely. IIRC, these are only relevant for windows where we implement sorting and such over the Win32 APIs. |
|
@ellismg I have created #8403 to track your suggestion. |
99 tasks
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mismatch between
sortversioning.handsertversioning.cppcausesfunction declared 'stdcall' here was previously declared without calling conventioncompile error during x86/Linux build.This commit revises
sortversioning.hin order to make it consistent withsertversioning.cpp.