Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

[x86/Linux] Uses portable ROTATE_LEFT for x86/Linux #8367

Merged
merged 1 commit into from
Nov 30, 2016

Conversation

parjong
Copy link

@parjong parjong commented Nov 29, 2016

The current PAL implementation defines _lrotl only for 64-bit architecture, which results in x86/Linux build failure.

This commit revises md5.cpp to use portable ROTATE_LEFT which is already used for ARM.

@parjong
Copy link
Author

parjong commented Nov 29, 2016

\CC @seanshpark

@parjong parjong changed the title Uses portable ROTATE_LEFT for x86/Linux [x86/Linux] Uses portable ROTATE_LEFT for x86/Linux Nov 29, 2016
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you!

@janvorli janvorli merged commit 8421585 into dotnet:master Nov 30, 2016
@parjong parjong deleted the fix/x86_md5_build branch November 30, 2016 23:16
@karelz karelz modified the milestone: 2.0.0 Aug 28, 2017
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants