This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
[x86/Linux] Declare GetCallerSp when WIN64EXCEPTION (not _TARGET_X86_) is defined #8372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetExactGenericsToken in eetwain.cpp (enclosed by WIN64EXCEPTION) calls GetCallerSp, but eetwain.h declares GetCallerSp only when _TARGET_X86_ is defined. This results in compile error for x86/Linux build. This commit revises eetwain.h to declare GetCallerSp when WIN64EXCEPTION is defined.
|
\CC @seanshpark |
parjong
changed the title
|
This should go together with a matching fix in the .cpp file. Let's close this for now and focus on the !WIN64EXCEPTIONS path. |
99 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetExactGenericsToken in eetwain.cpp (enclosed by WIN64EXCEPTION) calls
GetCallerSp, but eetwain.h declares GetCallerSp only when TARGET_X86
is defined.
This results in compile error for x86/Linux build.
This commit revises eetwain.h to declare GetCallerSp when WIN64EXCEPTION
is defined.