Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

[x86/Linux] Fix prototype for GCThreadStub #8397

Merged
merged 1 commit into from
Nov 30, 2016
Merged

[x86/Linux] Fix prototype for GCThreadStub #8397

merged 1 commit into from
Nov 30, 2016

Conversation

seanshpark
Copy link

Fix compile error for x86/Linux

  • fix "cannot initialize a parameter of type 'LPTHREAD_START_ROUTINE'"
  • add __stdcall GCThreadStub as it's Windows/Linux common code

Fix compile error for x86/Linux
- fix "cannot initialize a parameter of type 'LPTHREAD_START_ROUTINE'"
- add __stdcall GCThreadStub as it's Windows/Linux common code
@seanshpark
Copy link
Author

cc @parjong

Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@@ -72,7 +72,7 @@ LPWSTR HackyConvertToWSTR(char* pszInput);

typedef pthread_t THREAD_ID;
typedef void* (*MacWorker)(void*);
typedef DWORD (*LPTHREAD_START_ROUTINE)(void*);
typedef DWORD __stdcall (*LPTHREAD_START_ROUTINE)(void*);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI, this is unrelated to the GCThreadStub (but the fix is correct)

@janvorli janvorli merged commit fa6222d into dotnet:master Nov 30, 2016
@seanshpark seanshpark deleted the x86vm05 branch December 5, 2016 02:05
@karelz karelz modified the milestone: 2.0.0 Aug 28, 2017
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Fix compile error for x86/Linux
- fix "cannot initialize a parameter of type 'LPTHREAD_START_ROUTINE'"
- add __stdcall GCThreadStub as it's Windows/Linux common code

Commit migrated from dotnet/coreclr@fa6222d
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants