This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
[x86/Linux] Use Portable SHIFT JIT Helpers #8448
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables portable SHFIT JIT Helpers for x86/Linux.
|
\CC @seanshpark |
|
This won't work for x86. These JIT helpers have custom calling convention on x86. They have to be implemented in assembly on x86. The alternative would be to change the JIT, but it is more complex change and it would introduce divergence between x86 Windows and x86 Unix codegen. We may end up with some divergence between x86 Windows and x86 Unix codegen, but it would be good idea to minimize it. |
|
@jkotas Is it same for all the other JIT helpers? |
|
The custom calling convention applies only to the shift helpers that you are touching in this PR. |
|
@jkotas Thank you for comment! |
99 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables portable SHFIT JIT Helpers for x86/Linux.