-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change ReadOnlySpan indexer to return ref readonly #23582
Comments
Sounds fine to me. |
Good change. ReadonlySpan<HugeNestedStruct> h = ObtainSomehow();
int iOnlyNeedAnInt = h[42].Some.Deep.Nested.IntField; |
Sounds fine to me. |
Great. Thanks! |
Yes def should do this |
FYI: The API review discussion was recorded - see https://youtu.be/b96co3sNzNI?t=2423 (2 min duration) |
Can someone please explain the distinction between There is inconsistency in this particular issue, the title says:
The API change proposed (which is probably correct) says: @ektrah, can you please update the title? Returning
The indexer should return cc @VSadov |
Oops, sorry for the confusion. I've updated the title. (It's really confusing that read-only references are denoted by |
…e ReadOnlySpan indexer to return ref readonly. Related to https://github.com/dotnet/corefx/issues/24105 / dotnet/coreclr#14727. [tfs-changeset: 1683794]
See https://github.com/dotnet/corefx/issues/23881#issuecomment-328741859.
The text was updated successfully, but these errors were encountered: