Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests that write various large sizes of JSON using JsonSerializer.Serialize(Async) #30264

Closed
ahsonkhan opened this issue Jul 15, 2019 · 1 comment
Assignees
Labels
area-System.Text.Json test-enhancement Improvements of test source code
Milestone

Comments

@ahsonkhan
Copy link
Contributor

From dotnet/corefx#39417 (comment)

We should add more tests to verify that serializing (outputting) large JSON works as expected. It would be good to add test sizes around 4, 8, 12, 16k (particularly 12/16k as they are currently special sizes for SerializeAsync), and also some larger payloads above 85k. It would also be good to add tests where depth changes at those size threshold (for example, writing a start or end array/object at the 16k bytes).

More context: dotnet/corefx#39417 (comment)

The default threshold is 75% of the default buffer size (16K) so 12K. However it really determines what is returned from the array pool.

cc @steveharter, @buyaa-n, @layomia

@buyaa-n buyaa-n self-assigned this Jul 16, 2019
@buyaa-n
Copy link
Contributor

buyaa-n commented Nov 15, 2019

Fixed with dotnet/corefx#39668

@buyaa-n buyaa-n closed this as completed Nov 15, 2019
@msftgits msftgits transferred this issue from dotnet/corefx Feb 1, 2020
@msftgits msftgits added this to the 5.0 milestone Feb 1, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Text.Json test-enhancement Improvements of test source code
Projects
None yet
Development

No branches or pull requests

3 participants