This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Large json serialization/deserialization tests #39668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buyaa-n
added
area-System.Text.Json
test enhancement
bartonjs
reviewed
Jul 22, 2019
bartonjs
reviewed
Jul 22, 2019
buyaa-n
commented
Jul 25, 2019
buyaa-n
commented
Jul 25, 2019
|
@bartonjs @ahsonkhan comments addressed, please re-review |
eiriktsarpalis
changed the title
|
@ahsonkhan @bartonjs please re review |
bartonjs
reviewed
Aug 15, 2019
bartonjs
reviewed
Aug 15, 2019
bartonjs
reviewed
Aug 15, 2019
bartonjs
reviewed
Aug 15, 2019
bartonjs
reviewed
Aug 15, 2019
ahsonkhan
reviewed
Aug 16, 2019
ahsonkhan
reviewed
Aug 17, 2019
src/System.Text.Json/tests/Serialization/SampleTestData.BlogPost.cs
Outdated
Show resolved
Hide resolved
|
Looks like @buyaa-n addressed feedback, can folks please re-review? I've kicked off another test run since previous one was a couple weeks old. |
|
@ahsonkhan @bartonjs please re review |
stephentoub
reviewed
Oct 4, 2019
src/System.Text.Json/tests/Serialization/SampleTestData.BlogPost.cs
Outdated
Show resolved
Hide resolved
|
Thank you for your contribution. As announced in dotnet/coreclr#27549 this repository will be moving to dotnet/runtime on November 13. If you would like to continue working on this PR after this date, the easiest way to move the change to dotnet/runtime is:
|
stephentoub
reviewed
Nov 12, 2019
src/System.Text.Json/tests/Serialization/SampleTestData.Order.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Nov 12, 2019
src/System.Text.Json/tests/Serialization/SampleTestData.Order.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Nov 12, 2019
src/System.Text.Json/tests/Serialization/SampleTestData.Order.cs
Outdated
Show resolved
Hide resolved
ahsonkhan
reviewed
Nov 13, 2019
ahsonkhan
reviewed
Nov 13, 2019
ahsonkhan
reviewed
Nov 13, 2019
|
Unrelated System.Net.Http.Functional.Tests failure: https://github.com/dotnet/corefx/issues/26539#issuecomment-553630592 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tought its better to use large object close to real world example. So used BlogSpot json class from @layomia's Real world tests PR #39094.
Added 2 tests: one for large size object producing json with size from 6kB to 15MB, another for an object with deep nested structure up to max supported depth.