-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks @stephentoub
The PropertiesOfValidDrive test still seem to fail while running on my Ubuntu Docker image on windows.
|
Hmm. Wes, can you see what string is being passed into the GetDriveType function: |
null. Here is what we get back from the call to GetFormatInfoFromMountPoint: We get a buffer of with all zero's which Marshal.PtrToStringAnsi returns null for. |
Thanks, Wes. Looks like that value corresponds to overlayfs, which is a file system that effectively wraps other file systems. The good news is it's easy for us to add to the table. The bad news is we don't really know what kind of file system it is, since it's wrapping one or more others, so we'll need to weaken the test. |
Add drvfs and lxfs to GetDriveType Commit migrated from dotnet/corefx@67cc728
Fixes https://github.com/dotnet/corefx/issues/11570
cc: @karelz, @weshaggard