Replaced ContainsKey() Calls with TryAdd() Dictionary Calls #17201

rionmonster · 2017-03-16T19:51:49Z

Replaced usage of the Dictionary.ContainsKey() method with the newer Dictionary.TryAdd() method (where applicable) for performance benefits per Issue #17034.

This involved replacing this pattern:

if(!dictionary.ContainsKey(key))
{
        dictionary.Add(key, value);
}

with:

if (dictionary.TryAdd(key, value))
{
        // Code
}

Current Progress (Source)

System.CodeDom [Unsupported]
~~- [ ] ...\src\System\CodeDom\CodeNamespaceImportCollection.cs(34)~~

System.ComponentModel.TypeConverter

...\src\System\ComponentModel\ReflectTypeDescriptionProvider.cs(451)
...\src\System\ComponentModel\ReflectTypeDescriptionProvider.cs(489)

System.Data.Common

...\src\System\Data\DataView.cs(1333) [reverted]
...\src\System\Data\Common\AdapterUtil.cs(1185)

System.Data.SqlClient [Unsupported]
~~- [ ] ...\src\System\Data\Common\AdapterUtil.cs(976)~~
~~- [ ] ...\src\System\Data\SqlClient\SNI\SNIMarsConnection.cs(241)~~

System.Diagnostics [Unsupported]
~~- [ ] ...\src\System\Diagnostics\Tracing\EventSource.cs(6272)~~

System.DirectoryServices.AccountManagement [Unsupported]
~~- [ ] ...\src\System\DirectoryServices\AccountManagement\AD\ADDNLinkedAttrSet.cs(326)~~
~~- [ ] ...\src\System\DirectoryServices\AccountManagement\AD\ADDNLinkedAttrSet.cs(343)~~
~~- [ ] ...\src\System\DirectoryServices\AccountManagement\AD\ADDNLinkedAttrSet.cs(505)~~
~~- [ ] ...\src\System\DirectoryServices\AccountManagement\AD\ADDNLinkedAttrSet.cs(523)~~
~~- [ ] ...\src\System\DirectoryServices\AccountManagement\AD\ADDNLinkedAttrSet.cs(682)~~
~~- [ ] ...\src\System\DirectoryServices\AccountManagement\AD\ADDNLinkedAttrSet.cs(810)~~
~~- [ ] ...\src\System\DirectoryServices\AccountManagement\AD\ADStoreCtx_Query.cs(1178)~~

System.IO.Compression [Unsupported]
~~- [ ] ...\src\System\IO\Compression\ZipArchive.cs(368)~~

System.Linq.Expressions

...\src\System\Linq\Expressions\Compiler\BoundConstants.cs(87)
...\src\System\Linq\Expressions\Interpreter\LightCompiler.cs(1636)
...\src\System\Linq\Expressions\Interpreter\LightCompiler.cs(1690)

System.Net.NetworkInformation [Unsupported]
~~- [ ] ...\src\System\Net\NetworkInformation\NetworkAddressChange.Windows.cs(104)~~
~~- [ ] ...\src\System\Net\NetworkInformation\NetworkAddressChange.Windows.cs(225)~~

System.Private.DataContractSerialization

...\src\System\Runtime\Serialization\DataContract.cs(2109)
...\src\System\Runtime\Serialization\HybridObjectCache.cs(45)
...\src\System\Runtime\Serialization\Json\JsonDataContract.cs(293)
...\src\System\Runtime\Serialization\Json\JsonDataContract.cs(302)

System.Private.Xml [Unsupported]
~~- [ ] ...\src\System\Xml\Dom\DocumentSchemaValidator.cs(195)~~
~~- [ ] ...\src\System\Xml\Dom\DocumentSchemaValidator.cs(203)~~
~~- [ ] ...\src\System\Xml\Dom\XmlNodeReader.cs(1015)~~
~~- [ ] ...\src\System\Xml\Dom\XmlNodeReader.cs(1023)~~
~~- [ ] ...\src\System\Xml\Schema\DtdParser.cs(1437)~~
~~- [ ] ...\src\System\Xml\Schema\DtdParser.cs(1444)~~
~~- [ ] ...\src\System\Xml\Schema\DtdParserAsync.cs(1033)~~
~~- [ ] ...\src\System\Xml\Schema\DtdParserAsync.cs(1040)~~
~~- [ ] ...\src\System\Xml\Schema\DtdParserAsync.cs(1124)~~
~~- [ ] ...\src\System\Xml\Schema\SchemaCollectionCompiler.cs(292)~~
~~- [ ] ...\src\System\Xml\Schema\SchemaCollectionCompiler.cs(772)~~
~~- [ ] ...\src\System\Xml\Schema\SchemaCollectionCompiler.cs(779)~~
~~- [ ] ...\src\System\Xml\Schema\SchemaInfo.cs(356)~~
~~- [ ] ...\src\System\Xml\Schema\SchemaInfo.cs(364)~~
~~- [ ] ...\src\System\Xml\Schema\SchemaInfo.cs(371)~~
~~- [ ] ...\src\System\Xml\Schema\SchemaInfo.cs(378)~~
~~- [ ] ...\src\System\Xml\Schema\SchemaInfo.cs(385)~~
~~- [ ] ...\src\System\Xml\Schema\SchemaSetCompiler.cs(158)~~
~~- [ ] ...\src\System\Xml\Schema\SchemaSetCompiler.cs(842)~~
~~- [ ] ...\src\System\Xml\Schema\XdrBuilder.cs(1052)~~
~~- [ ] ...\src\System\Xml\Schema\XmlSchema.cs(210)~~
~~- [ ] ...\src\System\Xml\Serialization\Compilation.cs(304)~~
~~- [ ] ...\src\System\Xml\Xsl\IlGen\StaticDataManager.cs(30)~~
~~- [ ] ...\src\System\Xml\Xsl\Xslt\Compiler.cs(104)~~
~~- [ ] ...\src\System\Xml\Xsl\Xslt\Compiler.cs(172)~~
~~- [ ] ...\src\System\Xml\Xsl\XsltOld\XsltCompileContext.cs(274)~~
~~- [ ] ...\tests\XmlSchema\XmlSchemaValidatorApi\ExceptionVerifier.cs(174)~~
~~- [ ] ...\tests\Xslt\XslTransformApi\ExceptionVerifier.cs(174)~~

System.Private.Xml.Linq
~~- [ ] ...\src\System\Xml\Schema\XNodeValidator.cs(156)~~

System.Reflection.Metadata [Unsupported]
~~- [ ] ...\src\System\Reflection\Metadata\Internal\NamespaceCache.cs(406)~~

System.Runtime.Serialization

...\src\System\Runtime\Serialization\SerializationObjectManager.cs(30)

System.Security.AccessControl [Unsupported]
~~- [ ] ...\src\System\Security\AccessControl\Privilege.cs(150)~~

System.ServiceProcess.ServiceController [Unsupported]
~~- [ ] ...\src\System\ServiceProcess\ServiceController.cs(274)~~
~~- [ ] ...\src\System\ServiceProcess\ServiceController.cs(280)~~

Current Progress (Tests)

Common

...\tests\System\Collections\IDictionary.Generic.Tests.cs(769)
...\tests\System\Collections\IDictionary.Generic.Tests.cs(800)
...\tests\System\Collections\IDictionary.Generic.Tests.cs(836)

System.Collections

...\tests\Performance\Perf.Dictionary.cs(23)

System.Data.SqlClient

...\tests\ManualTests\SQL\Common\InternalConnectionWrapper.cs(160)

System.Linq.Expressions

...\tests\ILReader\ILPrinter.cs(123)

System.Private.Xml.Linq

...\tests\TreeManipulation\XAttributeEnumRemove.cs(248)
...\tests\TreeManipulation\XNodeSequenceRemove.cs(738)
...\tests\xNodeBuilder\XmlReaderDiff.cs(42)

…plicable) Replaced `ContainsKey()` method calls with the new `TryAdd()` method where applicable.

stephentoub · 2017-03-16T20:00:22Z

src/System.Data.Common/src/System/Data/DataView.cs

@@ -1330,9 +1330,9 @@ internal void MaintainDataView(ListChangedType changedType, DataRow row, bool tr
                        _addNewRow = null;
                        _addNewMoved = new ListChangedEventArgs(ListChangedType.ItemMoved, index, Count - 1);
                    }
-                    else if (!_rowViewCache.ContainsKey(row))
+                    else if (_rowViewCache.TryAdd(row, buffer ?? new DataRowView(this, row)))


This should be reverted: if buffer is null, we'll end up allocating a new DataRowView even if row is already in the _rowViewCache.

stephentoub · 2017-03-16T20:02:08Z

src/System.Linq.Expressions/src/System/Linq/Expressions/Interpreter/LightCompiler.cs

                    {
-                        caseDict.Add(key, caseOffset);
+                        // Offset was added


This can just be:

else { caseDict.TryAdd(key, caseOffset); }

stephentoub · 2017-03-16T20:04:00Z

...stem.Private.DataContractSerialization/src/System/Runtime/Serialization/HybridObjectCache.cs

            {
-                _referencedObjectDictionary.Add(id, null);
+                // Id was added
            }


Same as in the earlier example, this can just be:

else { _referencedObjectDictionary.TryAdd(id, null); }

danmoseley · 2017-03-16T20:07:41Z

src/System.Private.DataContractSerialization/src/System/Runtime/Serialization/DataContract.cs

-                        {
-                            knownDataContracts.Add(itemDataContract.StableName, itemDataContract);
-                        }
+                        knownDataContracts.TryAdd(itemDataContract.StableName, itemDataContract);


I think we generally only follow close brace by a blank line, close brace, or an else. Although I don't see that in https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/coding-style.md

Done.

And if that's missing, we may want to consider adding it in there. :)

Reverted to earlier approach to avoid unnessary allocation of a new row.

Removed the `TryAdd()` call from within the conditional statements and moved them to the body

Updated various unit tests to include the `TryAdd()` instead of the previous `ContainsKey()` pattern. This focused primarily on test casts that were not dictionary-related at all to help curb any potential regression issues.

Replaced older `ContainsKey()` implementation with newer `TryAdd()`.

rionmonster · 2017-03-17T14:52:36Z

As far as the 'Vertical netfx Build' not working goes, should we revert the changes that were introduced to the tests?

It appears that the current tooling in Visual Studio recognized and allowed the tests to run and build locally, however this particular build didn't recognize the TryAdd() method on a few of the tests, namely here:

error CS1061: 'Dictionary>' does not contain a definition for 'TryAdd' and no extension method 'TryAdd' accepting a first argument of type 'Dictionary>' could be found (are you missing a using directive or an assembly reference?) [D:\j\workspace\netfx_debug_p---88b09898\src\System.Private.Xml.Linq\tests\TreeManipulation\System.Xml.Linq.TreeManipulation.Tests.csproj]

and here, here, and here:

error CS1061: 'Dictionary>' does not contain a definition for 'TryAdd' and no extension method 'TryAdd' accepting a first argument of type 'Dictionary>' could be found (are you missing a using directive or an assembly reference?) [D:\j\workspace\netfx_debug_p---88b09898\src\System.Private.Xml.Linq\tests\TreeManipulation\System.Xml.Linq.TreeManipulation.Tests.csproj]

And it would seem based on the discussion within the issues area that the items which are unchecked are not going to support this new API at this time, so it's likely we can ignore those. So these changes should be implemented everywhere that currently supports them.

stephentoub · 2017-03-17T14:55:48Z

should we revert the changes that were introduced to the tests?

No, the tests that use .NET Core-specific surface area just need to be in their own files that are then only included when building the tests for .NET Core, e.g.
https://github.com/rionmonster/corefx/blob/ca9aab926cfa33bf1496de250e64c663bc249379/src/System.Collections/tests/System.Collections.Tests.csproj#L12
So those tests just need to be separated out into their own file(s), which would then be added into this portion of the .csproj.

rionmonster · 2017-03-17T16:00:57Z

@stephentoub

As far as the existing tests go, there aren't many that will need to be migrated. For instance the Perf.Dictionary test will actually use this new TryAdd() call within a static method that is then used within a majority of the tests in that file:

public static Dictionary<int, int> CreateDictionary(int size)
{
            Random rand = new Random(837322);
            Dictionary<int, int> dict = new Dictionary<int, int>();
            while (dict.Count < size)
            {
                int key = rand.Next(500000, int.MaxValue);
                if (!dict.ContainsKey(key))
                    dict.Add(key, 0);
            }
            return dict;
}

Should I keep the old implementation within this current file and simply create a new Perf.Dictionary.netcoreapp.Tests.cs file with the new implementation? Or would it be fine to just move this entire file over to use the newer one (and forget the previous approach entirely)?

Changed test to earlier implementation in to make way for .NET Core specific tests using newer API.

Copied the existing dictionary performance tests (from `Perf.Dictionary.cs`) and used the newer `TryAdd()` calls; Adjusted the projects test file only include these when targeting .NET Core.

tarekgh · 2017-03-17T16:51:07Z

Maybe we can create extension method for netfx that does TryAdd so we don't have to fork the code that using TryAdd method.

Reverted previous usage of the newer `TryAdd()` method and created a separate .NET Core specific file to to be conditionally included and tested.

Reverted previous changes involving the `TryAdd()` method and created a seperate file to test this functionality only for .NET Core.

Reverted previous changes to the normal tests and created a seperate test targeting .NET Core with the newer `TryAdd()` usage.

rionmonster · 2017-03-17T17:39:40Z

I just pushed up some changes shifted out the .NET Core specific tests into their own files. The API changes were generally involved in a single method that was used throughout the tests (i.e. CreateDictionary()) so I simply created another version of the same tests, one using the new API calls and the older versions remained the same.

…Collisions Applied Compilation Condition for InternalConnectionWrapper to Avoid Collisions (i.e. either build for .NET Core or use the other one for non-Core builds)

Added a .NET Core compilation constraint for the .NET Core specific ILPrinter class to avoid issues when building (i.e. only build .NET Core or non-Core).

Added a .NET Core compilation constraint for the .NET Core specific Performance Dictionary testing class to avoid issues when building (i.e. only build .NET Core or non-Core).

danmoseley · 2017-03-20T23:27:14Z

src/Common/tests/System/Collections/DictionaryExtensions.cs

+                dict.Add(key, value);
+                return true;
+            }
+            return false;


Nit, we try to have only blank line, 'else', or close curly, directly after close curly.

tarekgh · 2017-03-20T23:31:45Z

src/System.Collections/tests/Performance/System.Collections.Performance.Tests.csproj

@@ -9,6 +9,7 @@
  <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' " />
  <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' " />
  <ItemGroup>
+    <Compile Include="$(CommonTestPath)\System\Collections\DictionaryExtensions.cs" />


as Dan mentioned please add the Link element for having VS show such files nicely in the project view.

tarekgh · 2017-03-20T23:32:02Z

src/System.Collections.Concurrent/tests/System.Collections.Concurrent.Tests.csproj

@@ -10,6 +10,7 @@
  <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'netstandard-Debug|AnyCPU'" />
  <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'netstandard-Release|AnyCPU'" />
  <ItemGroup>
+    <Compile Include="$(CommonTestPath)\System\Collections\DictionaryExtensions.cs" />


tarekgh · 2017-03-20T23:32:17Z

src/System.Collections.Immutable/tests/System.Collections.Immutable.Tests.csproj

@@ -14,6 +14,7 @@
  <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'uap-Debug|AnyCPU'" />
  <PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'uap-Release|AnyCPU'" />
  <ItemGroup>
+    <Compile Include="$(CommonTestPath)\System\Collections\DictionaryExtensions.cs" />


[](start = 0, length = 3)

ditto

tarekgh · 2017-03-20T23:32:56Z

src/System.Data.SqlClient/tests/ManualTests/System.Data.SqlClient.ManualTesting.Tests.csproj

@@ -10,6 +10,7 @@
    <DefineConstants>$(DefineConstants);MANAGED_SNI</DefineConstants>
  </PropertyGroup>
  <ItemGroup>
+    <Compile Include="$(CommonTestPath)\System\Collections\DictionaryExtensions.cs" />


[](start = 1, length = 3)

ditto

danmoseley · 2017-03-20T23:34:01Z

LGTM

tarekgh · 2017-03-20T23:34:20Z

src/System.Linq.Expressions/tests/System.Linq.Expressions.Tests.csproj

@@ -280,6 +280,7 @@
    </Compile>
  </ItemGroup>
  <ItemGroup Condition=" '$(IsInterpreting)' != 'true' ">
+    <Compile Include="$(CommonTestPath)\System\Collections\DictionaryExtensions.cs" />


[](start = 0, length = 1)

ditto

tarekgh · 2017-03-20T23:35:40Z

...System.Private.Xml.Linq/tests/TreeManipulation/System.Xml.Linq.TreeManipulation.Tests.csproj

@@ -10,6 +10,7 @@
  <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
  </PropertyGroup>
  <ItemGroup>
+    <Compile Include="$(CommonTestPath)\System\Collections\DictionaryExtensions.cs" />


tarekgh · 2017-03-20T23:36:17Z

src/System.Private.Xml.Linq/tests/xNodeBuilder/System.Xml.Linq.xNodeBuilder.Tests.csproj

@@ -10,6 +10,7 @@
  <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
  </PropertyGroup>
  <ItemGroup>
+    <Compile Include="$(CommonTestPath)\System\Collections\DictionaryExtensions.cs" />


tarekgh · 2017-03-20T23:38:00Z

other than the minor comments, LGTM. thanks for getting this ready and clean :-)

Fixed Coding Style Issue of a missing blank line following the closing gullwing brace for the if-statement.

Updated all of the previously added extension method `<Compile>` sections to include a `<Link>` section to improve formatting.

rionmonster · 2017-03-21T13:19:03Z

The recent commits should address all of the issues that were previously mentioned (i.e. code formatting within the extension method and the addition of the <Link> sections within all of the previously added references).

Let me know if anything else jumps out :)

tarekgh · 2017-03-21T16:37:41Z

src/System.Collections/tests/System.Collections.Tests.csproj

@@ -69,6 +69,7 @@
    <Compile Include="$(CommonTestPath)\System\ObjectCloner.cs">
      <Link>Common\System\ObjectCloner.cs</Link>
    </Compile>
+    <Compile Include="$(CommonTestPath)\System\Collections\DictionaryExtensions.cs" />


<Compile Include="$(CommonTestPath [](start = 2, length = 36)

you missed adding the link element here.

Added Missing <Link> Section for Dictionary Extensions

rionmonster · 2017-03-21T17:36:00Z

Nice catch!

I had just gone over he previous comments and didn't see it mentioned. It should be good to go now.

tarekgh · 2017-03-21T17:42:04Z

LGTM. thanks again @rionmonster

we'll wait the green CI and then will merge it.

stephentoub · 2017-03-21T18:55:25Z

src/System.Private.Xml.Linq/tests/TreeManipulation/XAttributeEnumRemove.cs

                {
-                    expectedAttrsForParent.Add(p, p.Attributes().Except(copyAllAttributes.Where(x => x != null)).Select(a => new ExpectedValue(true, a)).ToList());
+                    expectedAttrsForParent.TryAdd(p, p.Attributes().Except(copyAllAttributes.Where(x => x != null)).Select(a => new ExpectedValue(true, a)).ToList());


This change needs to be reverted. It's adding a lot of expense even if the key is already in the dictionary.

Ah, wait, this is just in a test. Nevermind, that's fine.

stephentoub · 2017-03-21T18:55:36Z

src/System.Private.Xml.Linq/tests/TreeManipulation/XNodeSequenceRemove.cs

                {
-                    expectedNodesForParent.Add(p, p.Nodes().Except(toRemoveCopy.Where(x => x != null)).Select(a => new ExpectedValue(!(a is XText), a)).ProcessNodes().ToList());
+                    expectedNodesForParent.TryAdd(p, p.Nodes().Except(toRemoveCopy.Where(x => x != null)).Select(a => new ExpectedValue(!(a is XText), a)).ProcessNodes().ToList());


Ditto; this needs to be reverted.

Nevermind; I see now this is a test rather than product source.

stephentoub

LGTM. Thanks!

danmoseley · 2017-03-21T20:02:26Z

@rionmonster (can't rmeember whether I mentioned this before) if you'd like to take on something else, these are the "most wanted" as they're in our 2.0 milestone, which will ship in not long:

https://github.com/dotnet/corefx/issues?q=is%3Aopen+is%3Aissue+label%3A%22up+for+grabs%22+milestone%3A2.0.0

Perhaps there's something there that's interesting to you. If so just ask to be assigned it.

Replaced ContainsKey() Calls with TryAdd() Dictionary Calls (Where Ap…

0b52b01

…plicable) Replaced `ContainsKey()` method calls with the new `TryAdd()` method where applicable.

dnfclas added the cla-already-signed label Mar 16, 2017

stephentoub reviewed Mar 16, 2017

View reviewed changes

danmoseley reviewed Mar 16, 2017

View reviewed changes

rionmonster added 5 commits March 16, 2017 15:17

Reverted TryAdd() To Previous Approach

4502d53

Reverted to earlier approach to avoid unnessary allocation of a new row.

Cleaned Up else-if Usage with TryAdd()

0a9805c

Removed the `TryAdd()` call from within the conditional statements and moved them to the body

Added Extra Line for Readability / Coding Style

360c66e

Updated Non-Dictionary Test Cases To Use TryAdd()

b2cb4da

Updated various unit tests to include the `TryAdd()` instead of the previous `ContainsKey()` pattern. This focused primarily on test casts that were not dictionary-related at all to help curb any potential regression issues.

Added TryAdd() Within Dictionary Performance Test

ca9aab9

Replaced older `ContainsKey()` implementation with newer `TryAdd()`.

karelz added the area-Meta label Mar 17, 2017

karelz assigned rionmonster and tarekgh Mar 17, 2017

tarekgh added this to the Future milestone Mar 17, 2017

rionmonster added 2 commits March 17, 2017 11:43

Reverted PerfDictionary Test to ContainsKey() Usage

6f656ca

Changed test to earlier implementation in to make way for .NET Core specific tests using newer API.

Created Separate .NET Core Dictionary Performance Test

626264b

Copied the existing dictionary performance tests (from `Perf.Dictionary.cs`) and used the newer `TryAdd()` calls; Adjusted the projects test file only include these when targeting .NET Core.

rionmonster added 4 commits March 17, 2017 11:55

Created Separate .NET Core SQL Manual Test

29d423b

Reverted previous usage of the newer `TryAdd()` method and created a separate .NET Core specific file to to be conditionally included and tested.

Separated .NET Core ILPrinter Test

f170e7e

Reverted previous changes involving the `TryAdd()` method and created a seperate file to test this functionality only for .NET Core.

Created Seperate .NET Core Linq TreeManipulation Tests

a486eb1

Reverted previous changes to the normal tests and created a seperate test targeting .NET Core with the newer `TryAdd()` usage.

Created Seperate .NET Core xNodeBuilder Test

1321fbe

Reverted previous changes to the normal tests and created a seperate test targeting .NET Core with the newer `TryAdd()` usage.

rionmonster added 4 commits March 17, 2017 15:09

Missed .NET Core Reference for InternalConnectionWrapper

89271ce

Applied Compilation Condition for InternalConnectionWrapper to Avoid …

760d077

…Collisions Applied Compilation Condition for InternalConnectionWrapper to Avoid Collisions (i.e. either build for .NET Core or use the other one for non-Core builds)

Avoiding Another Build Collision with .NET Core Functionality

76fe06c

Added a .NET Core compilation constraint for the .NET Core specific ILPrinter class to avoid issues when building (i.e. only build .NET Core or non-Core).

Fixed Yet Another Potential Build Collision with .NET Core

cce562b

Added a .NET Core compilation constraint for the .NET Core specific Performance Dictionary testing class to avoid issues when building (i.e. only build .NET Core or non-Core).

danmoseley reviewed Mar 20, 2017

View reviewed changes

tarekgh reviewed Mar 20, 2017

View reviewed changes

rionmonster added 2 commits March 21, 2017 08:16

Fixed Coding Style Issue

f54f541

Fixed Coding Style Issue of a missing blank line following the closing gullwing brace for the if-statement.

Added <Link> Section for Extension Method References

1c1e9c1

Updated all of the previously added extension method `<Compile>` sections to include a `<Link>` section to improve formatting.

tarekgh reviewed Mar 21, 2017

View reviewed changes

Added <Link> Section for Dictionary Extensions

7090697

Added Missing <Link> Section for Dictionary Extensions

stephentoub reviewed Mar 21, 2017

View reviewed changes

stephentoub approved these changes Mar 21, 2017

View reviewed changes

stephentoub merged commit 3d4d803 into dotnet:master Mar 21, 2017

karelz modified the milestones: Future, 2.0.0 Mar 31, 2017

rionmonster deleted the tryadd-replacements branch April 4, 2017 14:39

rionmonster restored the tryadd-replacements branch April 4, 2017 14:41

rionmonster deleted the tryadd-replacements branch April 4, 2017 14:41

mellinoe mentioned this pull request Jul 3, 2017

Updating xUnit Performance Api and Performance Tests #21773

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replaced ContainsKey() Calls with TryAdd() Dictionary Calls #17201

Replaced ContainsKey() Calls with TryAdd() Dictionary Calls #17201

rionmonster commented Mar 16, 2017 •

edited

Loading

stephentoub Mar 16, 2017

rionmonster Mar 16, 2017

stephentoub Mar 16, 2017

rionmonster Mar 16, 2017

stephentoub Mar 16, 2017

rionmonster Mar 16, 2017

danmoseley Mar 16, 2017 •

edited

Loading

rionmonster Mar 16, 2017

rionmonster commented Mar 17, 2017

stephentoub commented Mar 17, 2017

rionmonster commented Mar 17, 2017

tarekgh commented Mar 17, 2017

rionmonster commented Mar 17, 2017

danmoseley Mar 20, 2017

tarekgh Mar 20, 2017

tarekgh Mar 20, 2017

tarekgh Mar 20, 2017

tarekgh Mar 20, 2017

danmoseley commented Mar 20, 2017

tarekgh Mar 20, 2017

tarekgh Mar 20, 2017

tarekgh Mar 20, 2017

tarekgh commented Mar 20, 2017

rionmonster commented Mar 21, 2017

tarekgh Mar 21, 2017

rionmonster commented Mar 21, 2017

tarekgh commented Mar 21, 2017

stephentoub Mar 21, 2017

stephentoub Mar 21, 2017

stephentoub Mar 21, 2017

stephentoub Mar 21, 2017

stephentoub left a comment

danmoseley commented Mar 21, 2017

Replaced ContainsKey() Calls with TryAdd() Dictionary Calls #17201

Replaced ContainsKey() Calls with TryAdd() Dictionary Calls #17201

Conversation

rionmonster commented Mar 16, 2017 • edited Loading

Current Progress (Source)

Current Progress (Tests)

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

danmoseley Mar 16, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rionmonster commented Mar 17, 2017

stephentoub commented Mar 17, 2017

rionmonster commented Mar 17, 2017

tarekgh commented Mar 17, 2017

rionmonster commented Mar 17, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

danmoseley commented Mar 20, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tarekgh commented Mar 20, 2017

rionmonster commented Mar 21, 2017

Choose a reason for hiding this comment

rionmonster commented Mar 21, 2017

tarekgh commented Mar 21, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stephentoub left a comment

Choose a reason for hiding this comment

danmoseley commented Mar 21, 2017

rionmonster commented Mar 16, 2017 •

edited

Loading

danmoseley Mar 16, 2017 •

edited

Loading