This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Add dll to netfx references to force bindingRedirects #18300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This dll has a reference to the earliest version of every contract desktop ever shipped. This will ensure that RAR sees conflicts and adds binding redirects.
weshaggard
reviewed
Apr 13, 2017
| </ItemGroup> | ||
|
|
||
| <Target Name="DumpVersions" DependsOnTargets="ResolveReferences"> | ||
| <Message Text="%(ReferencePath.FusionName)" /> |
There was a problem hiding this comment.
Did this list of versions look correct?
There was a problem hiding this comment.
Yes. Everything followed the 4.0.n0.0 pattern.
weshaggard
reviewed
Apr 13, 2017
src/netfx.force.conflict/dir.props
Outdated
| <Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
| <Import Project="..\dir.props" /> | ||
| <PropertyGroup> | ||
| <AssemblyVersion>0.0.0.0</AssemblyVersion> |
There was a problem hiding this comment.
Any particular reason you are given this assembly version 0?
There was a problem hiding this comment.
Because we should not version it. It won't show up in any typerefs.
weshaggard
reviewed
Apr 13, 2017
src/netfx.force.conflict/dir.props
Outdated
| <Import Project="..\dir.props" /> | ||
| <PropertyGroup> | ||
| <AssemblyVersion>0.0.0.0</AssemblyVersion> | ||
| <AssemblyKey>MSFT</AssemblyKey> |
There was a problem hiding this comment.
I can do that. I didn't want to add a new signing problem.
There was a problem hiding this comment.
The signing problem exists regardless of this assembly.
weshaggard
approved these changes
Apr 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dll has a reference to the earliest version of every contract
desktop ever shipped.
This will ensure that RAR sees conflicts and adds binding redirects.
Fixes #7702
/cc @weshaggard