Random span-based API tests #23692
Random span-based API tests #23692
Conversation
| @@ -54,13 +54,35 @@ public static void Seeded() | |||
| } | |||
|
|
|||
| [Fact] | |||
| public static void ExpectedValues() | |||
| public static void Seeded_Span() | |||
There was a problem hiding this comment.
Missing test passing a zero length span.
| @@ -54,13 +54,35 @@ public static void Seeded() | |||
| } | |||
|
|
|||
| [Fact] | |||
| public static void ExpectedValues() | |||
| public static void Seeded_Span() | |||
There was a problem hiding this comment.
I expect you're going to need to separate this test out into its own file that's only built when targeting netcoreapp. The test project has netstandard configurations, and the new API won't be available there. Some examples are here: https://github.com/dotnet/corefx/blob/master/src/System.Runtime.Extensions/tests/System.Runtime.Extensions.Tests.csproj#L35-L44
|
@dotnet-bot test UWP NETNative x86 Release Build Couldn't delete workspace. |
|
Need to either baseline the uap errors or wait a few days for new project N bits. I suggest the latter. |
|
@dotnet-bot test UWP NETNative x86 Release Build |
* Random span extensions * Random span tests * random span tests * Test configurations * Fixed item group condition Commit migrated from dotnet/corefx@94a3498
Added tests for Span API in Random class. References https://github.com/dotnet/corefx/issues/22356.
Depends on dotnet/coreclr#13708.