Updating corefx to use new roslyn compiler #24076

joperezr · 2017-09-15T17:51:13Z

cc: @weshaggard @ericstj

FYI: @ahsonkhan @RussKeldorph @VSadov since you were interested in corefx using a newer compiler

This PR will update the version of the roslyn compiler that we use in corefx.

JonHanna · 2017-09-15T18:19:29Z

This reminds me that I meant to open an issue about discards not working in corefx. Will this fix that?

joperezr · 2017-09-15T18:40:31Z

It should since it will enable C#7 now.

joperezr · 2017-09-15T18:41:06Z

FYI: @stephentoub since this will make corefx be able to use C#7 features.

ericstj · 2017-09-15T19:00:24Z

Looks like desktop doesn't like the code generated for ImmutableCollections:

11:10:10       System.Collections.Immutable.Tests.ImmutableArrayBuilderTest.MoveToImmutableAfterClear [FAIL]
11:10:10         System.Security.VerificationException : Operation could destabilize the runtime.
11:10:10         Stack Trace:
11:10:10              at System.Collections.Immutable.ImmutableArray`1.Builder.ToArray()
11:10:10         System.Security.VerificationException : Operation could destabilize the runtime.
11:10:10         Stack Trace:
11:10:10              at System.Collections.Immutable.ImmutableHashSet`1.HashBucket.Enumerator.MoveNext()
11:10:10           D:\j\workspace\windows-TGrou---2a8f9c29\src\System.Collections.Immutable\src\System\Collections\Immutable\ImmutableHashSet_1.Enumerator.cs(83,0): at System.Collections.Immutable.ImmutableHashSet`1.Enumerator.MoveNext()
11:10:10           D:\j\workspace\windows-TGrou---2a8f9c29\src\System.Collections.Immutable\src\System\Collections\Immutable\ImmutableHashSet_1.cs(737,0): at System.Collections.Immutable.ImmutableHashSet`1.Overlaps(IEnumerable`1 other, MutationInput origin)
11:10:10           D:\j\workspace\windows-TGrou---2a8f9c29\src\System.Collections.Immutable\src\System\Collections\Immutable\ImmutableHashSet_1.cs(372,0): at System.Collections.Immutable.ImmutableHashSet`1.Overlaps(IEnumerable`1 other)
11:10:10           D:\j\workspace\windows-TGrou---2a8f9c29\src\System.Collections.Immutable\tests\ImmutableSetTest.cs(413,0): at System.Collections.Immutable.Tests.ImmutableSetTest.SetCompareTestHelper[T](Func`2 operation, Func`2 baselineOperation, IEnumerable`1 scenarios)
11:10:10         System.Security.VerificationException : Operation could destabilize the runtime.
11:10:10         Stack Trace:
11:10:10              at System.Collections.Immutable.ImmutableArray`1.Builder.ToArray()
11:10:10           D:\j\workspace\windows-TGrou---2a8f9c29\src\System.Collections.Immutable\tests\ImmutableArrayBuilderTest.cs(443,0): at System.Collections.Immutable.Tests.ImmutableArrayBuilderTest.ToImmutable()
11:10:10         System.Security.VerificationException : Operation could destabilize the runtime.
11:10:10         Stack Trace:
11:10:10              at System.Collections.Immutable.ImmutableHashSet`1.HashBucket.Enumerator.MoveNext()
11:10:10           D:\j\workspace\windows-TGrou---2a8f9c29\src\System.Collections.Immutable\src\System\Collections\Immutable\ImmutableHashSet_1.Enumerator.cs(83,0): at System.Collections.Immutable.ImmutableHashSet`1.Enumerator.MoveNext()
11:10:10              at System.Collections.Generic.HashSet`1.UnionWith(IEnumerable`1 other)
11:10:10              at System.Collections.Generic.HashSet`1..ctor(IEnumerable`1 collection, IEqualityComparer`1 comparer)
11:10:10           D:\j\workspace\windows-TGrou---2a8f9c29\src\System.Collections.Immutable\tests\ImmutableSetTest.cs(546,0): at System.Collections.Immutable.Tests.ImmutableSetTest.ExceptTestHelper[T](IImmutableSet`1 set, T[] valuesToRemove)

Lots and lots of these. Seems like it could be a compiler (or compiler+JIT) issue /cc @tmat

ahsonkhan · 2017-09-15T19:18:24Z

....Runtime.Serialization.Formatters/tests/System.Runtime.Serialization.Formatters.Tests.csproj

@@ -4,6 +4,7 @@
  <PropertyGroup>
    <ProjectGuid>{13CE5E71-D373-4EA6-B3CB-166FF089A42A}</ProjectGuid>
    <SkipIncludeNewtonsoftJson>true</SkipIncludeNewtonsoftJson>
+    <LangVersion>7.2</LangVersion>


Quesiton: Would we need to update the csproj of other assemblies (like System.Memory) to include LangVersion 7.2 if we want to use the ref keyword i.e. here: https://github.com/dotnet/corefx/pull/23908/files?

Yes, at least that was required for ref structs so for now I only did it in places where we used it. If we think we will want to use it everywhere, then we can set this property at the dir.props level later on so that it is not replicated on every project.

This should be added to the top level props file instead.

Yes lets try and move that to dir.props.

@joperezr are you planning to move this to dir.props in a followup?

If so, please also remove it from some of the places where I added it recently:
https://github.com/dotnet/corefx/pull/23908/files#diff-718e92a9d68dbfe993253e67ac1863f6R9

* Buildtools is getting updated to use a roslyn compiler that will cause errors without this fix. * See dotnet/corefx#24076

stephentoub · 2017-09-15T21:12:41Z

Seems like it could be a compiler (or compiler+JIT) issue

cc: @VSadov

stephentoub

Once CI passes, LGTM. Thanks for getting this in, @joperezr.

* Buildtools is getting updated to use a roslyn compiler that will cause errors without this fix. * See dotnet/corefx#24076

VSadov · 2017-09-17T01:23:11Z

I will take a look at ImmutableCollections. Interested what code hits that.

In some cases we may do optimizations that verifier does not like. My guess is that Immutable sets [SecurityTransparent] which causes verification at jit time and hits such optimization. Newer builds of compiler have an option to disable that. We talked with @joperezr and he will try newer build with a flag set for Immutable.

It could also be just a bug though :)

CC: @jaredpar

jaredpar · 2017-09-18T15:12:22Z

Looks like desktop doesn't like the code generated for ImmutableCollection

what tool is being run here?

stephentoub · 2017-09-18T15:14:02Z

what tool is being run here?

The error is coming from the runtime while executing the immutable collection tests in corefx.

jkotas · 2017-09-18T16:34:10Z

System.Collections.Immutable is marked as SecurityTransparent assembly (#3847). SecurityTransparent assemblies have to be fully verifiable. In .NET Framework, the code is verified at runtime even when you are running in full trust. It is where the exception is coming from.

weshaggard · 2017-09-18T17:17:38Z

src/Microsoft.XmlSerializer.Generator/tests/Microsoft.XmlSerializer.Generator.Tests.csproj

@@ -54,7 +54,7 @@
      <SerializerName>$(AssemblyName).XmlSerializers</SerializerName>
    </PropertyGroup>
    <Message Text="Running Serialization Tool" Importance="normal" />
-    <Exec Command="$(GeneratorCliPath)dotnet $(OutputPath)dotnet-Microsoft.XmlSerializer.Generator.dll $(OutputPath)Microsoft.XmlSerializer.Generator.Tests.dll /force /casesensitive"  />


Why is this change needed?

It is actually very weird, but I started getting an error saying that the /casesensitive parameter is not recognized

OK.
cc @huanwu

joperezr · 2017-09-18T17:59:44Z

Newer builds of compiler have an option to disable that. We talked with @joperezr and he will try newer build with a flag set for Immutable.

I have tried this with a newer version of the compiler and set the flag and now the tests pass just fine. I'll make the update on buildtools side and then update this PR to get all CI passing.

…ass on desktop

joperezr · 2017-09-18T21:41:36Z

@VSadov the netfx tests now pass just fine with the new compiler, but now one System.Reflection.Metadata test failed on all configurations with the following error:

     System.Reflection.Metadata.Decoding.Tests.SignatureDecoderTests.PinnedAndUnpinnedLocals [FAIL]
        Assert.Contains() Failure
        Not found: uint8& pinned
        In value:  ImmutableArray<String> ["uint8[]", "uint8*", "uint8[] pinned", "int32"]

Any idea what might be going on here? cc: @tmat

jkotas · 2017-09-18T22:11:03Z

@tmat is OOF.

It is fragile test that makes assumptions about the exact IL generated for fixed. It should be updated or related to reflect Roslyn changes.

joperezr · 2017-09-18T23:07:29Z

The failing test on that Linux machine is a random segfault that is not related to my PR. It is happening in System.Drawing on the Debian leg (cc: @mellinoe )

/home/helixbot/dotnetbuild/work/915f7222-9ffa-4f7f-8ce8-d6d5355597b1/Work/82dbbdcd-e7f1-4289-993a-4323d0b19f5c/Unzip/RunTests.sh: line 87: 116226 Segmentation fault      (core dumped) $RUNTIME_PATH/dotnet xunit.console.netcore.exe System.Drawing.Common.Tests.dll -xml testResults.xml -notrait Benchmark=true -notrait category=nonnetcoreapptests -notrait category=nonlinuxtests -notrait category=OuterLoop -notrait category=failing

joperezr · 2017-09-19T00:01:48Z

Merging now since CI is now passing (other than that debian system.drawing test)

* Microsoft.ServiceModel.Syndication skeleton project * Adding the existing classes of SyndicationFeed from .net fx * Added the needed references to get the code to compile * Changed some namespaces * Fixed errors when reading feeds and replaced some buffers * Cleaning code for PR * Deleted some unused files * Added the posibility that the user creates his own date parser when reading a feed from outside, also as part of our default date parser, if it can't parse the date it will just assign a default date to avoid the crash * Added correct testnames and Copyright * Initial changes to add custom parsers * Added more delegates as parsers * Added custom parser delegates * Save changes * Initial SyndicationFeed * Removed the dependence of the old SR class * Cleaned the code, deleted Diagnostics, fixed throwing resources * Cleaned code from most of the unnecesary comments * Formatted the code with CodeFormatter Tool * Moved the call of itemParser to be called with each item * Test using custom parsers * Fixed image issue where image tag was using original title and url, for RSS formatting Image issue fixed and added some tests * Test clase jorge * Save changes with Jorge cass * Initial Jorge * saving changes * Save changes * Fixed image and items issue * Fixed disjoint items in atom * Run codeFormatter * Adding parsing to optional elements int the spec added unittesting * Added Icon parsing to Atom10 feedFormatter. Added unit test * Adding Async Writing RssFormater writes new optional spec elements * Added Icon writing on Arom Writer * Fixed some warnings * Improved custom parsing for RSS * Added custom parsing for Atom feed formatter, added test * added nameof() to all exceptions when needed. * Adding Extension Methods for XmlReader * Fixing code for PR * Fixing code for PR * Added check for skip days to allow only accepted days. * Improved flexibility for Default dateparser * Add wrong dates example * Fixing code review * Fixed warnings on some unawaited methods. * Added async extension methods for XmlReader * Add XmlWriterWrapper method extensions * Changed ReadCategoryFromAsync to return a SyndicationCategory * Fixed sync method exposed GetReader. * Edited XmlReaderWrapper, moved methods to extension methods. * Removed unnecesary variables from Wrappers. * Fixed bug from ServiceModel.Syndication * Make BigInteger ctor opt path for == int.MinValue reachable. The BigInteger(ReadOnlySpan<byte> value) ctor contains an optimised path for value being larger than 4 bytes and the result being equal to int.MinValue. However this path is inside a test that precludes that value, so can never be reached. Restructure so that the path is reachable. * Fix ServiceModel.SyndicationFeed project dependencies - Change M.SM.SyndicationFeed to be a .NET Standard 2.0 library - Change tests to use official .NET Core 2.0 release from preview * Add btrfs and other missing file system types (dotnet#24102) * Uppercase * Add more filesystems from stat.c. Change to stat names where possible * Add some more local friendly names * Add some more remote file types from stat.c * Add entry to switch present in enum * Build errors * Remove Fixed entries that should be RAM * comment * Change case of 0X to 0x * Move cramfs to Fixed * ConcurrentQueue 128-byte cache line (dotnet#22724) ConcurrentQueue 128-byte cache line * Add warning by default in SGEN (dotnet#24054) * Output warning by default if run the tool directly without /quiet parameter. * add quiet parameter in the command. * fix parameter error. * Update the warning. * Add the target to copy the serializer to publish folder. (dotnet#24096) * Wrap cert callback leaked exceptions in WinHttpHandler (dotnet#24107) Similar to the fix done for CurlHandler (dotnet#21938), fix WinHttpHandler so that leaked exceptions from the user-provided certificate callback are properly wrapped. The ManagedHandler still needs to be fixed since it is not wrapping properly. Contributes to #21904 * Ensure ProcessModule for main executable is first in modules list (dotnet#24106) * Disable NegotiateStreamTest fixture for distros without working Kerberos (dotnet#24098) Disable NegotiateStreamTest fixture entirely because setup-kdc.sh is broken on some distros * Expose and add tests for Guid.ctor(Span)/TryWriteBytes/TryFormat * Address remaining PR feedback * #24112 Replaced documentation summary of TryPop with text similar to TryDequeue. (dotnet#24113) * Wrap exceptions from ManagedHandler's server validation callback (dotnet#24111) To match other handlers' behaviors. * Fix libgdiplus function loading on OSX. * Prevent ServiceControllerTests from dispose when already disposed (dotnet#24042) * Disable ServiceProcessTest that has been failing on CI and official builds * Prevent dispose from been called when already disposed * Add logging to repro if RemoveService is been called twice on the same ServiceController * Data-annotations length fix (dotnet#24101) * Updated in MinLengthAttribute and MaxLengthAttribute to support ICollection<T> * Added tests * Fixed typo * Trying to address two failing checks: - Linux x64 Release Build - UWP CoreCLR x64 Debug Build * Implemented changes requested in review - Extracted Count checking to an external helper to obey DRY - Removed dependency of ICollection<T> and changed to simple reflection Count property lookup * Added requested tests * Added catch for MissingMetadataException. * Extracted code from try-catch. * Added comment as requested. * Typo correction * Remove System.Drawing.Common from the netfx compat package (temporary). * Updating corefx to use new roslyn compiler (dotnet#24076) * Updating corefx to use new roslyn compiler * Updating to new version of the compiler and use the switch so tests pass on desktop * Fix System.Reflection.Metadata tests * Stop running Math.Clamp tests on UAP as API is not there (dotnet#24125) * Stop running Math.Clamp tests on UAP as API is not there * Disable only for AOT * Fix instantiating PrincipleContext with Domain type (dotnet#24122) * Fix instantiating PrincipleContext with Domain type * Enhancement * Disable Test_Write_Metric_eventListener on UWP. (dotnet#24127) * Revert "Remove System.Drawing.Common from the netfx compat package (temporary)." This reverts commit f6b0fbd. * Update BuildTools, CoreClr, CoreFx, CoreSetup, Standard to prerelease-02019-01, preview1-25718-02, preview1-25718-03, preview1-25717-02, preview1-25718-01, respectively (dotnet#24075) * Fixed compile warning/error on FreeBSD (dotnet#24141) * Marking {ReadOnly}Span as readonly structs (dotnet#23908) * Marking {ReadOnly}Span as readonly structs, fixing issue #23809 * Adding readonly attributes to reference assemblies. * Using "readonly ref" keyword instead of attributes. * Adding a LangVersion 7.2 property * System.Drawing: Throw ArgumentNullException on Unix as well (dotnet#24140) * Throw ArgumentNullException when stream is null * Throw ArgumentNullException when stream is null * Remove invalid NameResolution tests (dotnet#24147) The Dns_GetHostEntryAsync_* are fundamentially invalid because it's possible for the broadcast address, 255.255.255.255, to have an DNS mapping via manually modifying the hosts file. This was actually happening on Mac systems as well as an virtual environment running on top of that (i.e. Windows on Parallels). Ref: https://github.com/dotnet/corefx/issues/23992#issuecomment-330250642 Contributes to #23992 * Bump system.drawing.common.testdata to 1.0.6 * Update BuildTools to prerelease-02019-02 (dotnet#24146) * Fix path to test data * Fix whitespace * Add GraphicsTests based on Mono's test suite. * Consolidate more code in the "System.Drawing" namespace. * Remove all remaining Win32 codepaths from the mono codebase. All of this code now implicitly assumes that it will be run on a Unix platform. * Consolidate the rest of the gdipFunctions.cs file into Gdip.cs and GdipNative.Unix.cs * Consolidate the GraphicsUnit and ImageType enumerations -- they were duplicated. * Remove the mono Status enum and use the Windows constants instead in all Unix code. * Move all files into the regular directory structure. Suffix them with ".Unix" and ".Windows" when there are collisions. * Tiny bit of code cleanup * Add conditionals for recent versions of mono * Remove duplicate tests. * Fix multiplying TextureBrush with a disposed matrix on Unix (dotnet#24109) * Fix multiplying TextureBrush with a disposed matrix on Unix * Enable another passing test * Fix accidentally committed file * Add an error code fixup to Bitmap.Unix.cs to match Windows. * Bump System.Drawing.Common.TestData to 1.0.6 (dotnet#24149) * Bump system.drawing.common.testdata to 1.0.6 * Fix path to test data * Fix whitespace * Cleanup - Add/simplify using statements of disposable resources (Graphics, Bitmap) * Validate HatchStyle passed to HatchBrush ctor * Delete accidentally duplicated HatchBrush tests in LinearGradientBrushTests * Remove references to historical Mono bug IDs * Renable some already passing tests * Remove Thread.Sleep workaround * Update BuildTools to prerelease-02020-01 (dotnet#24172) * Add thread-local based switch to opt-in to ManagedHandler * Address PR feedback * PR feedback * Fix memory map imports (dotnet#24176) * Fix memory map imports Imports lost the last error attribute. Add it back and change the results to be the more correct "bool". Tweak the usage based on the new return type. #24159 * Move spin wait * Remove unused FEATURE_RANDOMIZED_STRING_HASHING (dotnet#24178) * Adding System.Data.Odbc package and including in metapackage * Fix MultiplyTransform with a disposed brush * Fix for 2nd Connection hangs in Mirroring Environment (dotnet#24181) * Switch tests to use thread-local switch for ManagedHandler And as a result re-enable parallelism of the test suite, which on my machine reduces the running time of the outerloop tests from 150s to 45s. * Update CoreClr, CoreSetup, ProjectNTfs, ProjectNTfsTestILC, Standard to preview1-25720-03, preview1-25719-04, beta-25721-01, beta-25721-01, preview1-25721-01, respectively * CoreFx #22406 Span based APIs - Text Reader Writer (dotnet#23786) * [Drawing] Move remaining "Unix" files into regular directory structure * As part of this, the "Windows" version of ImageFormat.cs is now being used everywhere. This file just contains a bunch of GUID's that are not platform-specific in any way. * Change AsSpan to property Span and rename AsMemory to Memory * Add Metafile and MetaHeader tests based on Mono's System.Drawing unit tests * Update project file * MetafileTests: Remove duplicates, and re-enable tests on Unix which are now working. Delete duplicate MetaHeadertests * Rationalize using statements * Update project file * Fix Metafile exception behavior * Simplify tests, remove duplicate test * Don't catch an ArgumentException just to get a NullReferenceException instead. * Assert.False(Object.ReferenceEquals => Assert.NotSame * PR feedback * Remove duplicate tests, fix typo * Remove X11 dependency for tests which are enabled on Unix. * Workaround libgdiplus glitches Don't test metafileHeader.Bounds when using libgdiplus. Don't test metafile.GetBounds on Unix, force MetafileHeader.Bounds to return an empty rectangle when MetafileSize == 0 Don't validate graphicsUnit on Unix. * Move Syndication to root/src * Disable Build of S.SM.Syndication. * Increase file descriptor limit in S.N.Http tests on macOS * Expose/test String.Create span-based method (dotnet#23872) * Expose/test String.Create span-based method * Address PR feedback * Update build to clang/llvm 3.9 (dotnet#24177) Update scripts, docs and build pipeline docker images to clang/llvm/lldb 3.9 * Update ProjectNTfs, ProjectNTfsTestILC, Standard to beta-25722-00, beta-25722-00, preview1-25722-01, respectively (dotnet#24207) * Remove the line that will copy the generated serializer to the pack. (dotnet#24199) * Revert "Update build to clang/llvm 3.9 (dotnet#24177)" This reverts commit 21e008a. * Remove stale SetStateMachine call in test * Ssl Stream Async Write (dotnet#23715) * Change from APM to Async/Await for write side * Added nameof * Reacting to review * Reacting to review * SSLStream : Fixed spelling mistake in file name (extra a) (dotnet#24221) * Fixed spelling mistake in file name * Fix csproj * Update ProjectNTfs, ProjectNTfsTestILC to beta-25723-00, beta-25723-00, respectively (dotnet#24222)

* Updating corefx to use new roslyn compiler * Updating to new version of the compiler and use the switch so tests pass on desktop * Fix System.Reflection.Metadata tests (cherry picked from commit fc4b1ad) # Conflicts: # BuildToolsVersion.txt # src/System.Runtime.Serialization.Formatters/tests/FormatterServicesTests.cs # src/System.Runtime/tests/System/TypeTests.netcoreapp.cs

* Updating corefx to use new roslyn compiler * Updating to new version of the compiler and use the switch so tests pass on desktop * Fix System.Reflection.Metadata tests Commit migrated from dotnet/corefx@fc4b1ad

dnfclas added the cla-already-signed label Sep 15, 2017

joperezr mentioned this pull request Sep 15, 2017

Marking {ReadOnly}Span as readonly structs #23908

Merged

karelz added the area-Infrastructure-libraries label Sep 15, 2017

karelz assigned joperezr Sep 15, 2017

ahsonkhan reviewed Sep 15, 2017

View reviewed changes

StephenBonikowsky added a commit to StephenBonikowsky/wcf that referenced this pull request Sep 15, 2017

Updating WCF to use new roslyn compiler.

737ba90

* Buildtools is getting updated to use a roslyn compiler that will cause errors without this fix. * See dotnet/corefx#24076

StephenBonikowsky mentioned this pull request Sep 15, 2017

Update BuildTools version, and fix for new roslyn compiler. dotnet/wcf#2286

Merged

StephenBonikowsky added a commit to StephenBonikowsky/wcf that referenced this pull request Sep 15, 2017

Updating WCF to use new roslyn compiler.

39a9135

* Buildtools is getting updated to use a roslyn compiler that will cause errors without this fix. * See dotnet/corefx#24076

stephentoub approved these changes Sep 15, 2017

View reviewed changes

StephenBonikowsky added a commit to StephenBonikowsky/wcf that referenced this pull request Sep 15, 2017

Updating WCF to use new roslyn compiler.

b8ed225

* Buildtools is getting updated to use a roslyn compiler that will cause errors without this fix. * See dotnet/corefx#24076

StephenBonikowsky added a commit to StephenBonikowsky/wcf that referenced this pull request Sep 15, 2017

Updating WCF to use new roslyn compiler.

123d1d7

* Buildtools is getting updated to use a roslyn compiler that will cause errors without this fix. * See dotnet/corefx#24076

weshaggard reviewed Sep 18, 2017

View reviewed changes

joperezr closed this Sep 18, 2017

joperezr reopened this Sep 18, 2017

dnfclas added the cla-already-signed label Sep 18, 2017

joperezr mentioned this pull request Sep 18, 2017

Updating Roslyn to version 2.6.0-rdonly-ref-62111-06 dotnet/buildtools#1681

Merged

joperezr added 2 commits September 18, 2017 13:15

Updating corefx to use new roslyn compiler

05cec58

Updating to new version of the compiler and use the switch so tests p…

564809c

…ass on desktop

joperezr force-pushed the UpdateRoslyn branch from a19253a to 564809c Compare September 18, 2017 20:16

Fix System.Reflection.Metadata tests

b3369cf

joperezr merged commit fc4b1ad into dotnet:master Sep 19, 2017

karelz added this to the 2.1.0 milestone Oct 11, 2017

joperezr deleted the UpdateRoslyn branch March 28, 2018 20:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updating corefx to use new roslyn compiler #24076

Updating corefx to use new roslyn compiler #24076

joperezr commented Sep 15, 2017

JonHanna commented Sep 15, 2017

joperezr commented Sep 15, 2017

joperezr commented Sep 15, 2017

ericstj commented Sep 15, 2017

ahsonkhan Sep 15, 2017

joperezr Sep 15, 2017

jkotas Sep 16, 2017

weshaggard Sep 18, 2017

weshaggard Sep 19, 2017

ahsonkhan Sep 19, 2017

stephentoub commented Sep 15, 2017

stephentoub left a comment

VSadov commented Sep 17, 2017

jaredpar commented Sep 18, 2017

stephentoub commented Sep 18, 2017

jkotas commented Sep 18, 2017

weshaggard Sep 18, 2017

joperezr Sep 18, 2017

weshaggard Sep 18, 2017

joperezr commented Sep 18, 2017

joperezr commented Sep 18, 2017

jkotas commented Sep 18, 2017

joperezr commented Sep 18, 2017

joperezr commented Sep 19, 2017

Updating corefx to use new roslyn compiler #24076

Updating corefx to use new roslyn compiler #24076

Conversation

joperezr commented Sep 15, 2017

JonHanna commented Sep 15, 2017

joperezr commented Sep 15, 2017

joperezr commented Sep 15, 2017

ericstj commented Sep 15, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stephentoub commented Sep 15, 2017

stephentoub left a comment

Choose a reason for hiding this comment

VSadov commented Sep 17, 2017

jaredpar commented Sep 18, 2017

stephentoub commented Sep 18, 2017

jkotas commented Sep 18, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joperezr commented Sep 18, 2017

joperezr commented Sep 18, 2017

jkotas commented Sep 18, 2017

joperezr commented Sep 18, 2017

joperezr commented Sep 19, 2017