This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Moving Microsoft.ServiceModel.Syndication from wcf to corefx. #24202
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| | ||
| Microsoft Visual Studio Solution File, Format Version 12.00 | ||
| # Visual Studio 15 | ||
| VisualStudioVersion = 15.0.26430.12 | ||
| MinimumVisualStudioVersion = 10.0.40219.1 | ||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.ServiceModel.Syndication", "src\Microsoft.ServiceModel.Syndication.csproj", "{B615835F-C286-4FB5-A2BF-C3B967AB9EC6}" | ||
| EndProject | ||
| Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Microsoft.ServiceModel.Syndication.Tests", "tests\Microsoft.ServiceModel.Syndication.Tests.csproj", "{A622B2C0-DD74-4218-9CF0-F9B2E52F4E91}" | ||
| EndProject | ||
| Global | ||
| GlobalSection(SolutionConfigurationPlatforms) = preSolution | ||
| Debug|Any CPU = Debug|Any CPU | ||
| Release|Any CPU = Release|Any CPU | ||
| EndGlobalSection | ||
| GlobalSection(ProjectConfigurationPlatforms) = postSolution | ||
| {B615835F-C286-4FB5-A2BF-C3B967AB9EC6}.Debug|Any CPU.ActiveCfg = Debug|Any CPU | ||
| {B615835F-C286-4FB5-A2BF-C3B967AB9EC6}.Debug|Any CPU.Build.0 = Debug|Any CPU | ||
| {B615835F-C286-4FB5-A2BF-C3B967AB9EC6}.Release|Any CPU.ActiveCfg = Release|Any CPU | ||
| {B615835F-C286-4FB5-A2BF-C3B967AB9EC6}.Release|Any CPU.Build.0 = Release|Any CPU | ||
| {A622B2C0-DD74-4218-9CF0-F9B2E52F4E91}.Debug|Any CPU.ActiveCfg = Debug|Any CPU | ||
| {A622B2C0-DD74-4218-9CF0-F9B2E52F4E91}.Debug|Any CPU.Build.0 = Debug|Any CPU | ||
| {A622B2C0-DD74-4218-9CF0-F9B2E52F4E91}.Release|Any CPU.ActiveCfg = Release|Any CPU | ||
| {A622B2C0-DD74-4218-9CF0-F9B2E52F4E91}.Release|Any CPU.Build.0 = Release|Any CPU | ||
| EndGlobalSection | ||
| GlobalSection(SolutionProperties) = preSolution | ||
| HideSolutionNode = FALSE | ||
| EndGlobalSection | ||
| EndGlobal | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
| </Project> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <Project ToolsVersion="14.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | ||
| </Project> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
|
|
||
|
|
||
| namespace Microsoft.ServiceModel.Syndication | ||
|
There was a problem hiding this comment.
|
||
| { | ||
| internal static class App10Constants | ||
|
There was a problem hiding this comment. To be consistent with the other components in corefx, the source files should be nested under their namespace components (for example, see Instead of:
Change to:
(applies throughout) There was a problem hiding this comment. Yes, will change this later in separate PR. |
||
| { | ||
| public const string Accept = "accept"; | ||
| public const string Categories = "categories"; | ||
| public const string Collection = "collection"; | ||
| public const string Fixed = "fixed"; | ||
| public const string Href = "href"; | ||
| public const string Namespace = "http://www.w3.org/2007/app"; | ||
| public const string Prefix = "app"; | ||
| public const string Service = "service"; | ||
| public const string Workspace = "workspace"; | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
| // See the LICENSE file in the project root for more information. | ||
|
|
||
|
|
||
|
|
||
| namespace Microsoft.ServiceModel.Syndication | ||
| { | ||
| public static class Atom10Constants | ||
| { | ||
| public const string AlternateTag = "alternate"; | ||
| public const string Atom10Namespace = "http://www.w3.org/2005/Atom"; | ||
| public const string Atom10Prefix = "a10"; | ||
| public const string AtomMediaType = "application/atom+xml"; | ||
| public const string AuthorTag = "author"; | ||
| public const string CategoryTag = "category"; | ||
| public const string ContentTag = "content"; | ||
| public const string ContributorTag = "contributor"; | ||
| public const string EmailTag = "email"; | ||
| public const string EntryTag = "entry"; | ||
| public const string FeedTag = "feed"; | ||
| public const string GeneratorTag = "generator"; | ||
| public const string HrefTag = "href"; | ||
| public const string HtmlMediaType = "text/html"; | ||
| public const string HtmlType = "html"; | ||
| public const string IdTag = "id"; | ||
| public const string LabelTag = "label"; | ||
| public const string LengthTag = "length"; | ||
| public const string LinkTag = "link"; | ||
| public const string LogoTag = "logo"; | ||
| public const string NameTag = "name"; | ||
| public const string PlaintextType = "text"; | ||
| public const string PublishedTag = "published"; | ||
| public const string RelativeTag = "rel"; | ||
| public const string RightsTag = "rights"; | ||
| public const string SchemeTag = "scheme"; | ||
| public const string SelfTag = "self"; | ||
| public const string SourceFeedTag = "source"; | ||
| public const string SourceTag = "src"; | ||
| public const string SpecificationLink = "http://atompub.org/2005/08/17/draft-ietf-atompub-format-11.html"; | ||
| public const string SubtitleTag = "subtitle"; | ||
| public const string SummaryTag = "summary"; | ||
| public const string TermTag = "term"; | ||
| public const string TitleTag = "title"; | ||
| public const string TypeTag = "type"; | ||
| public const string UpdatedTag = "updated"; | ||
| public const string UriTag = "uri"; | ||
| public const string XHtmlMediaType = "application/xhtml+xml"; | ||
| public const string XHtmlType = "xhtml"; | ||
| public const string XmlMediaType = "text/xml"; | ||
| public const string IconTag = "icon"; | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sure you're aware but the project references and name of this solution file should be changed from
MicrosofttoSystem.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The csproj currently does not build in corefx. The PR is mainly for porting the code from wcf to corefx. I planned to enable the build of the project later and fix the namespace later for better code review experience.