This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Expose/test Span-based Convert methods #24474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joperezr
reviewed
Oct 6, 2017
| @@ -191,6 +191,7 @@ public static partial class Convert | |||
| public static int ToBase64CharArray(byte[] inArray, int offsetIn, int length, char[] outArray, int offsetOut, Base64FormattingOptions options) { throw null; } | |||
| public static string ToBase64String(byte[] inArray, Base64FormattingOptions options) { throw null; } | |||
| public static string ToBase64String(byte[] inArray, int offset, int length, Base64FormattingOptions options) { throw null; } | |||
| public static string ToBase64String(System.ReadOnlySpan<byte> bytes, Base64FormattingOptions options = Base64FormattingOptions.None) { throw null; } | |||
There was a problem hiding this comment.
Is this done in corert as well? If not then it will fail on uap and uapaot builds.
There was a problem hiding this comment.
Convert.cs is in the shared partition. Once it's merged into coreclr, it'll be mirrored over to corert.
There was a problem hiding this comment.
I see, that's great! I missed that part on your coreclr PR :)
joperezr
reviewed
Oct 6, 2017
| @@ -38,6 +38,7 @@ | |||
| <ItemGroup Condition="'$(TargetGroup)'!='netstandard'"> | |||
| <Compile Include="System\BitConverterSpan.cs" /> | |||
| <Compile Include="System\BitConverter.netcoreapp.cs" /> | |||
| <Compile Include="System\Convert.netcoreapp.cs" /> | |||
There was a problem hiding this comment.
NIT: This will also run on UWP but I guess we don't have a good naming conventions for non-netstandard stuff
joperezr
approved these changes
Oct 6, 2017
|
@dotnet-bot test this please |
|
@dotnet-bot test this please |
pjanotti
pushed a commit
to pjanotti/corefx
that referenced
this pull request
Oct 31, 2017
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Commit migrated from dotnet/corefx@602d2ed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on dotnet/coreclr#14358
Fixes https://github.com/dotnet/corefx/issues/22417
cc: @AlexGhiondea, @joperezr