This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Performance issue fix for manged sni #25621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saurabh500
approved these changes
Dec 1, 2017
corivera
approved these changes
Dec 1, 2017
|
Just out of curiosity, can someone describe why setting the buffer size led to a perf problem. As a general rule, you would have expected if 'upper levels' of the stack set the buffer size that they would have a better idea of a good value. This change basically removes calls to _socket.*BufferSize, and I am wondering if other uses of these socket APIs have a similar problem? |
saurabh500
pushed a commit
to saurabh500/corefx
that referenced
this pull request
Dec 20, 2017
geleems
pushed a commit
to geleems/corefx
that referenced
this pull request
Jan 9, 2018
saurabh500
pushed a commit
that referenced
this pull request
Jan 12, 2018
* Performace issue fix for manged sni (#25621) * Increased SqlClient assembly and package versions for servicing * corrected version number
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Commit migrated from dotnet/corefx@6126b43
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting buffer size of socket manually causes the performance issue. This is a fix for the issue: https://github.com/dotnet/corefx/issues/24480