Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Fix for SqlConnection failure when having multiple concurrent users #26247

Merged
merged 4 commits into from
Jan 12, 2018

Conversation

geleems
Copy link

@geleems geleems commented Jan 10, 2018

This is a fix for issue https://github.com/dotnet/corefx/issues/25620
In .NET Core 2.0, SqlConnection failed on not many multiple concurrent users during ASP.NET web application load testing.

@geleems geleems added this to the 2.0.x milestone Jan 10, 2018
@geleems geleems self-assigned this Jan 10, 2018
@geleems geleems merged commit 7ff205b into dotnet:release/2.0.0 Jan 12, 2018
@saurabh500
Copy link
Contributor

@geleems please port this test to master as well.

@geleems
Copy link
Author

geleems commented Jan 16, 2018

@saurabh Porting the test finished, and merged to main branch. #26306

@geleems geleems deleted the rel2new-2 branch February 16, 2018 00:15
@TheRubble
Copy link

Any idea on the release date for this?

@MStefanov
Copy link

Hello,
I saw the v2.1.0-preview1-26216-03 is already available, but I it seems this fix is not there and is marked for Servicing-Approved-2.0.6. Does this mean we should expect .NET Core 2.0.6 and this particular fix in this package? If so when do you think .NET Core 2.0.6 should be released? Thanks in advance

@danmoseley
Copy link
Member

2.0.6 is expected this month.

@saurabh500
Copy link
Contributor

@MStefanov The fix is available in SqlClient preview version 4.5.0-preview1-26216-02
What problems are you facing ? Can you open an issue and let us know what issues you are seeing?

@saurabh500
Copy link
Contributor

Also the same fix is going in 2.0.6
If something is not working in 4.5.0-preview with respect to connections, it may not work in 2.0.6 either.

@dude0001
Copy link

What version of the System.Data.SqlClient NuGet package do we need for this fix? We are targeting .NET Core 2.2 and using 4.6 of the NuGet package but running in to very similar issues in our docker containers. Trying to determine how we can tell if our connections are using this fix.

@danmoseley
Copy link
Member

@dude0001 can you please open a new issue - either here or in https://github.com/dotnet/SqlClient

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants