[No Merge] Merge SSE and SSE2 classes #29447
Conversation
| public static Vector128<long> Add(Vector128<long> left, Vector128<long> right) { throw null; } | ||
| public static Vector128<ulong> Add(Vector128<ulong> left, Vector128<ulong> right) { throw null; } | ||
| public static Vector128<double> Add(Vector128<double> left, Vector128<double> right) { throw null; } | ||
| public static Vector128<T> Add<T>(Vector128<T> left, Vector128<T> right) where T : struct { throw null; } |
There was a problem hiding this comment.
nit: If these were merged (and I still don't think it is a good idea), most of these would/could become generic.
|
@fiigii I agree with @tannergooding that it is not good idea to merge them. |
|
@fiigii, @CarolEidt, this can be closed now, right? |
|
@stephentoub The discussion https://github.com/dotnet/corefx/issues/29247 is still in progress and this PR is a demo for that thread. Once https://github.com/dotnet/corefx/issues/29247 gets a consensus, I will close this PR. |
|
Thanks. But a PR isn't needed for that, though; the discussion happens on the issue, and you can point people to your branch to see what it looks like (https://github.com/fiigii/corefx/commits/mergesse/). Having two places for the discussion to happen seems worse to me, plus it clutters up the PR list with a PR that won't actually be merged. |
|
@stephentoub Thanks for the explanation, closing. |
|
Thanks, @fiigii. |
For discussing https://github.com/dotnet/corefx/issues/29247
cc @CarolEidt @tannergooding @eerhardt @AndyAyersMS @jkotas