This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Removing Reference assets from packages which contain runtime-specific dependencies when targeting Desktop. #33510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c dependencies when targeting Desktop. (dotnet#33254) * Removing Reference assets from packages which contain runtime-specific dependencies when targeting Desktop. * Adding validation target to catch other instances of packages that need the property
ericstj
reviewed
Nov 14, 2018
| @@ -57,4 +57,12 @@ | |||
| <Message Text="DumpTargets> $(OutputPath), C=[$(Configuration)], CG=[$(ConfigurationGroup)], OG=[$(OSGroup)], TG=[$(TargetGroup)]" Importance="Low" /> | |||
| </Target> | |||
|
|
|||
| <!-- This target will be moved into buildtools. Checked in here for now to add validationand in order not to block buildtools ingestion. --> | |||
ericstj
reviewed
Nov 14, 2018
| @@ -6,14 +6,8 @@ | |||
| <SupportedFramework>net461;netcoreapp2.0;uap10.0.16299;$(UAPvNextTFM);$(AllXamarinFrameworks)</SupportedFramework> | |||
| </ProjectReference> | |||
| <ProjectReference Include="..\src\System.Data.SqlClient.csproj" /> | |||
| <HarvestIncludePaths Include="ref/net451;lib/net451;runtimes/win/lib/net451" /> | |||
| <HarvestIncludePaths Include="ref/net46;lib/net46;runtimes/win/lib/net46" /> | |||
| <HarvestIncludePaths Include="ref/netstandard1.2"> | |||
There was a problem hiding this comment.
Separate issue. I bet we could delete some live configurations from this package and harvest them giving the API isn't going to change and we have a shipping package with a version of the not-supported assemblies to harvest.
|
Warnings Errors |
…ackages that are not required any more.
Eilon
added
the
blocking
|
FYI marking this as blocking-partner because this is required for 3.0 Preview 1 for ASP.NET Core. |
Not really. What is really blocking ASP.NET now is a different PR due to signing issues #33387 |
|
Bunch of package validation failures. |
jlennox
pushed a commit
to jlennox/corefx
that referenced
this pull request
Dec 16, 2018
…c dependencies when targeting Desktop. (dotnet#33510) * Removing Reference assets from packages which contain runtime-specific dependencies when targeting Desktop. (dotnet#33254) * Removing Reference assets from packages which contain runtime-specific dependencies when targeting Desktop. * Adding validation target to catch other instances of packages that need the property * Fixing target to check all exclude compiles. Undoing changes on two packages that are not required any more. * Update package index to contain the right versions * Fixing packaging build errors
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…c dependencies when targeting Desktop. (dotnet/corefx#33510) * Removing Reference assets from packages which contain runtime-specific dependencies when targeting Desktop. (dotnet/corefx#33254) * Removing Reference assets from packages which contain runtime-specific dependencies when targeting Desktop. * Adding validation target to catch other instances of packages that need the property * Fixing target to check all exclude compiles. Undoing changes on two packages that are not required any more. * Update package index to contain the right versions * Fixing packaging build errors Commit migrated from dotnet/corefx@6832425
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting #33254 to master branch. I cherry-picked the change first and then fixed all of the conflicts regarding the move to using Directory.Build.props over dir.props and such, plus removing all of the package version changes.
cc: @ericstj @natemcmaster