Enable official portable musl build #34352
Conversation
There was a problem hiding this comment.
Does portable builds, have to also be enabled in official builds?
https://github.com/dotnet/corefx/blob/master/eng/pipelines/linux.yml#L46
https://github.com/dotnet/corefx/blob/master/eng/pipelines/linux.yml#L81
am11
changed the title
|
@safern, thanks for pointing it out, I have made the change in YAML file. I thought the groovy script is responsible for official builds. :) |
|
Are we OK with changing the build this way? As noted in the issue, we do not support LibreSSL officially. What are the consequences to scenarios that are supported? |
|
@danmosemsft The only change is that the openssl lookup happens at runtime. But we only scan for the openssl versions 1.0.x and 1.1.x. Unless the user sets the env variable CLR_OPENSSL_VERSION_OVERRIDE, it will not try to use the LibreSSL. |
|
OK |
* Enable portable builds in linux-musl.groovy * Enable official portable musl build * Add back Windowws_NT condition Commit migrated from dotnet/corefx@1072799
Portable builds are enabled by default. For
linux-muslit is explicitly disabled, which limits this package to be consumed in other muscle-based distros like Void Linux (which has a different name forlibssl:libssl.so.46, instead oflibssl.so.1.0.0).cc @janvorli, @weshaggard
Fixes https://github.com/dotnet/corefx/issues/34239