This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Make ReadToEnd static helper resilient against stream.Length changes. #34798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartonjs
approved these changes
Jan 24, 2019
A custom Stream type (or maybe an existing swiss-army-test-Stream) which claims 900 bytes of Length, then returns 2MB of 0x20, then ends in a 0x33. |
Yeah, basically just lie in your custom Stream.Length, e.g. return Length == 1 from a stream that contains a larger document, and validate that you get the document you expected. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying feedback from dotnet/core-setup#5009 (comment) where we were using the ReadToEnd static helper from corefx.
Do you have any suggestions on how to test this? I was trying to get one thread to read from the stream while another changes its length but couldn't get the test to fail since it relies on the timing of the get and set length. Any ideas on how to deterministically test the race condition?
cc @bartonjs, @stephentoub