This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Add runtime directive for DbDataReader.GetFieldValue<T> #3917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @saurabh500 |
|
@natemcmaster Can you provide more details about the change? A link to the issue ? |
|
cc @YoungGah |
|
When compiled through .NET Native, the metadata for this assembly is not included by default. This xml adds directives to ensure metadata is explicitly included. With out this, calls to GetFieldValue() may result in cref dotnet/efcore#623 |
saurabh500
added a commit
that referenced
this pull request
Oct 20, 2015
Add runtime directive for DbDataReader.GetFieldValue<T>
|
LGTM. I have merged the PR. |
|
@saurabh500 thanks! |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Add runtime directive for DbDataReader.GetFieldValue<T> Commit migrated from dotnet/corefx@89bb636
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables using this generic method on UWP apps where in some situations the netnative compiler leaves out the metadata.