Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

[master] Update dependencies from dotnet/coreclr #42443

Merged

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Nov 7, 2019

This pull request updates the following dependencies

From https://github.com/dotnet/coreclr

  • Build: 20191108.3
  • Date Produced: 11/9/2019 1:56 AM
  • Commit: a0bbdf98efd5b96c041d8b49d2a61d0ce5bf3212
  • Branch: refs/heads/master
  • Updates:
    • Microsoft.NET.Sdk.IL -> 5.0.0-alpha1.19558.3
    • Microsoft.NETCore.ILAsm -> 5.0.0-alpha1.19558.3
    • Microsoft.NETCore.Runtime.CoreCLR -> 5.0.0-alpha1.19558.3

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Nov 7, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: corefx-ci (MacOS Build x64_Debug), corefx-ci (Windows Build x64_Debug), corefx-ci (Linux Build musl_x64_Debug), corefx-ci (Linux Build x64_Debug), corefx-ci (Linux Build RedHat6_x64_Release)

@stephentoub stephentoub self-assigned this Nov 7, 2019
@stephentoub
Copy link
Member

stephentoub commented Nov 7, 2019

There's a Sockets test consistently failing here across all Unix legs
but only in this PR, which suggests there's something that changed in coreclr that's somehow breaking it.

public void SendRecvIovMaxTcp_Success()

In the compared byte arrays, there's a block of ~350 values (out of 2400) that's missing in the actual results, showing up as zeros, after the first 1024 values.

Expected: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95

Actual:
0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, 109, 110, 111, 112, 113, 114, 115, 116, 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 154, 155, 156, 157, 158, 159, 160, 161, 162, 163, 164, 165, 166, 167, 168, 169, 170, 171, 172, 173, 174, 175, 176, 177, 178, 179, 180, 181, 182, 183, 184, 185, 186, 187, 188, 189, 190, 191, 192, 193, 194, 195, 196, 197, 198, 199, 200, 201, 202, 203, 204, 205, 206, 207, 208, 209, 210, 211, 212, 213, 214, 215, 216, 217, 218, 219, 220, 221, 222, 223, 224, 225, 226, 227, 228, 229, 230, 231, 232, 233, 234, 235, 236, 237, 238, 239, 240, 241, 242, 243, 244, 245, 246, 247, 248, 249, 250, 251, 252, 253, 254, 255, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 72, 73, 74, 75, 76, 77, 78, 79, 80, 81, 82, 83, 84, 85, 86, 87, 88, 89, 90, 91, 92, 93, 94, 95

cc: @dotnet/ncl, @jkotas

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Nov 7, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (MacOS Build x64_Debug), corefx-ci (Windows Build x64_Debug), corefx-ci (Linux Build musl_x64_Debug), corefx-ci (Linux Build x64_Debug), corefx-ci (Linux Build RedHat6_x64_Release)

@jkotas
Copy link
Member

jkotas commented Nov 7, 2019

there's something that changed in coreclr that's somehow breaking it

I do not see anything obvious. We should binary search to find the offending changes. I can do it in the evening if nobody beats me to it.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Nov 7, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (Linux Build musl_x64_Debug), corefx-ci (MacOS Build x64_Debug), corefx-ci (Linux Build x64_Debug), corefx-ci (Linux Build RedHat6_x64_Release), corefx-ci (Windows Build x64_Debug)

@stephentoub
Copy link
Member

Doing a bisect now... will take a little while...

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Nov 7, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (Linux Build musl_x64_Debug), corefx-ci (MacOS Build x64_Debug), corefx-ci (Linux Build x64_Debug), corefx-ci (Linux Build RedHat6_x64_Release), corefx-ci (Windows Build x64_Debug)

@stephentoub
Copy link
Member

@jkotas, I did a git bisect on Ubuntu 18.04 between the two commits at https://github.com/dotnet/corefx/pull/42443/files#diff-5c6a1c77fe216efcfbbdccb11b863063R5, building coreclr/corefx along the way and running this test, and it found:

5e1ef698774c433f70795e194e2554ad6f5b7d6f is the first bad commit
commit 5e1ef698774c433f70795e194e2554ad6f5b7d6f
Author: Jan Kotas <[email protected]>
Date:   Tue Nov 5 08:10:37 2019 -0800

    Change BulkMoveWithWriteBarrier to be GC suspension friendly (#27642)

    * Change BulkMoveWithWriteBarrier to be GC suspension friendly

    * Rename RuntimeHelpers.cs

:040000 040000 15876535ea136d63a744c941c9acf11ce6fc0fb8 0fd05fe2958b098d6aeea231064bc5675ac9fb16 M      src

When I revert that commit from master, the test starts passing. I'm not sure why this particular test is affected so consistently and nothing else seems to be, but it does go down a path creating a couple thousand pinned GCHandles, and we probably don't have many tests that do that; maybe that's related.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Nov 7, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (Linux Build musl_x64_Debug), corefx-ci (MacOS Build x64_Debug), corefx-ci (Linux Build x64_Debug), corefx-ci (Linux Build RedHat6_x64_Release), corefx-ci (Windows Build x64_Debug)

@jkotas
Copy link
Member

jkotas commented Nov 8, 2019

Thank you! I am reverting the change in dotnet/coreclr#27758 until I have a chance to debug this. Looks like it is exposing a latent bug somewhere.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Nov 8, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Waiting on checks: corefx-ci, corefx-ci (MacOS Build x64_Debug), corefx-ci (Windows Build NETFX_x86_Release), corefx-ci (Windows Build x86_Release), corefx-ci (Windows Packaging All Configurations x64_Debug), corefx-ci (Windows Build x64_Debug), corefx-ci (Linux Build arm64_Debug), corefx-ci (Linux Build musl_arm64_Debug), corefx-ci (Linux Build musl_x64_Debug), corefx-ci (Linux Build arm_Debug), corefx-ci (Linux Build x64_Debug), corefx-ci (Linux Build wasm_Release), corefx-ci (Linux Build RedHat6_x64_Release)

@stephentoub
Copy link
Member

I am reverting the change

Thanks. I opened https://github.com/dotnet/coreclr/issues/27769 to track the reversion, and included a non-sockets repro.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Nov 8, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (MacOS Build x64_Debug), corefx-ci (Linux Build arm64_Debug), corefx-ci (Linux Build musl_x64_Debug), corefx-ci (Linux Build musl_arm64_Debug), corefx-ci (Linux Build x64_Debug), corefx-ci (Linux Build arm_Debug), corefx-ci (Linux Build wasm_Release), corefx-ci (Linux Build RedHat6_x64_Release)

@stephentoub
Copy link
Member

With the latest update, this is now failing to build on Unix with:

##[error]System.Runtime.CompilerServices.Unsafe.il(5,0): error : syntax error at token 'coreassembly.h"' in: #include "coreassembly.h"

I'm guessing this is due to dotnet/coreclr#27704?
cc: @jkoritzinsky, @Tyrrrz

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Nov 8, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (MacOS Build x64_Debug), corefx-ci (Linux Build arm64_Debug), corefx-ci (Linux Build musl_x64_Debug), corefx-ci (Linux Build musl_arm64_Debug), corefx-ci (Linux Build x64_Debug), corefx-ci (Linux Build arm_Debug), corefx-ci (Linux Build wasm_Release), corefx-ci (Linux Build RedHat6_x64_Release)

@stephentoub
Copy link
Member

I reverted the latest Microsoft.NET.Sdk.IL update; hopefully that fixes it. And opened https://github.com/dotnet/coreclr/issues/27772 for the build failure.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Nov 8, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Waiting on checks: corefx-ci (MacOS Build x64_Debug), corefx-ci (Windows Build NETFX_x86_Release), corefx-ci (Windows Build x86_Release), corefx-ci, corefx-ci (Windows Build x64_Debug), corefx-ci (Windows Packaging All Configurations x64_Debug), corefx-ci (Linux Build arm64_Debug), corefx-ci (Linux Build musl_x64_Debug), corefx-ci (Linux Build musl_arm64_Debug), corefx-ci (Linux Build arm_Debug), corefx-ci (Linux Build x64_Debug), corefx-ci (Linux Build wasm_Release), corefx-ci (Linux Build RedHat6_x64_Release)

@Tyrrrz
Copy link

Tyrrrz commented Nov 8, 2019

@stephentoub
Interesting. I'm having a hard time figuring out how that broke the build on Unix, but sorry if that's the case. At least the checks seem to have passed.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Nov 8, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: corefx-ci (MacOS Build x64_Debug)

@stephentoub
Copy link
Member

Looks like the coreclr build doesn't contain the Buffer revert. Will wait for that...

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Nov 8, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful No un-ignored checks.

@stephentoub
Copy link
Member

We're past most of the issue, but there's a crash now in System.Linq.Expressions, on all OSes on debug builds.

@jkotas, can you help take a look? Here's the crash output for the "Internal CLR error":

  Discovering: System.Linq.Expressions.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Linq.Expressions.Tests (found 5642 of 5652 test cases)
  Starting:    System.Linq.Expressions.Tests (parallel test collections = on, max threads = 2)
Fatal error. Internal CLR error. (0x80131506)
   at System.Linq.Expressions.Expression`1[[System.__Canon, System.Private.CoreLib, Version=5.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].get_PublicType()
   at System.Linq.Expressions.Expression.Quote(System.Linq.Expressions.Expression)
   at System.Linq.Expressions.Tests.DebugViewTests.Unary_Quote()
   ...

And there's a dump here:
https://helix.dot.net/api/2019-06-17/jobs/8fae13c8-8944-430e-b203-a0c179c9c784/workitems/System.Linq.Expressions.Tests/files/dotnet.exe.2912.dmp

0:009> !clrstack -f
OS Thread Id: 0xdb4 (9)
        Child SP               IP Call Site
000000001C728B60 000007FEE5ECA6A5 coreclr!MethodTable::HasSameTypeDefAs + 49 at F:\workspace\_work\1\s\src\vm\methodtable.cpp:654
000000001C728BA0 000007FEE5FDAAF3 coreclr!NoRemoveDefaultCrossLoaderAllocatorHashTraits<MethodTable *,MethodTable *>::VisitKeyValueStore<<lambda_e585c3fdb0e7cc83a8daf7ab162e9bdf> > + 83 at F:\workspace\_work\1\s\src\vm\crossloaderallocatorhash.inl:160
000000001C728C10 000007FEE5FDB09D coreclr!CrossLoaderAllocatorHash<Module::DynamicDictSlotsForTypesTrackerHashTraits>::VisitValuesOfKey<<lambda_e585c3fdb0e7cc83a8daf7ab162e9bdf> > + 189 at F:\workspace\_work\1\s\src\vm\crossloaderallocatorhash.inl:619
000000001C728CD0 000007FEE5FDC210 coreclr!Module::ExpandTypeDictionaries_Locked + 156 at F:\workspace\_work\1\s\src\vm\ceeload.cpp:13449
000000001C728EB0 000007FEE5FE83E9 coreclr!DictionaryLayout::FindToken + 517 at F:\workspace\_work\1\s\src\vm\genericdict.cpp:350
000000001C728F40 000007FEE5F0E76F coreclr!CEEInfo::ComputeRuntimeLookupForSharedGenericToken + 2199 at F:\workspace\_work\1\s\src\vm\jitinterface.cpp:3517
000000001C729070 000007FEE5E9675A coreclr!CEEInfo::embedGenericHandle + 1066 at F:\workspace\_work\1\s\src\vm\jitinterface.cpp:2695
000000001C729160 000007FEE5DD42A2 clrjit!Compiler::impTokenToHandle + 70 at F:\workspace\_work\1\s\src\jit\importer.cpp:1801
000000001C729200 000007FEE5D9632B clrjit!Compiler::impImportBlockCode + 20715 at F:\workspace\_work\1\s\src\jit\importer.cpp:15048
000000001C729DA0 000007FEE5D8F8BE clrjit!Compiler::impImportBlock + 222 at F:\workspace\_work\1\s\src\jit\importer.cpp:16993
000000001C729E80 000007FEE5D8F5FB clrjit!Compiler::impImport + 779 at F:\workspace\_work\1\s\src\jit\importer.cpp:18064
000000001C729EF0 000007FEE5D8E2BE clrjit!Compiler::compCompile + 158 at F:\workspace\_work\1\s\src\jit\compiler.cpp:4488
000000001C72A030 000007FEE5D8C5D7 clrjit!Compiler::compCompileHelper + 663 at F:\workspace\_work\1\s\src\jit\compiler.cpp:6165
000000001C72A0D0 000007FEE5D8AD99 clrjit!Compiler::compCompile + 553 at F:\workspace\_work\1\s\src\jit\compiler.cpp:5468
000000001C72A180 000007FEE5D8AA43 clrjit!jitNativeCode + 627 at F:\workspace\_work\1\s\src\jit\compiler.cpp:6793
000000001C72A340 000007FEE5D89CDD clrjit!CILJit::compileMethod + 141 at F:\workspace\_work\1\s\src\jit\ee_il_dll.cpp:319
000000001C72A3B0 000007FEE5EEEE68 coreclr!invokeCompileMethod + 212 at F:\workspace\_work\1\s\src\vm\jitinterface.cpp:12494
000000001C72A440 000007FEE5EEED04 coreclr!CallCompileMethodWithSEHWrapper + 80 at F:\workspace\_work\1\s\src\vm\jitinterface.cpp:12548
000000001C72A4E0 000007FEE5EEE6FC coreclr!UnsafeJitFunction + 4220 at F:\workspace\_work\1\s\src\vm\jitinterface.cpp:13035
000000001C72A8E0 000007FEE5EED46D coreclr!MethodDesc::JitCompileCodeLocked + 725 at F:\workspace\_work\1\s\src\vm\prestub.cpp:987
000000001C72AAC0 000007FEE5EEF241 coreclr!MethodDesc::JitCompileCodeLockedEventWrapper + 817 at F:\workspace\_work\1\s\src\vm\prestub.cpp:843
000000001C72AC10 000007FEE5EEF8BF coreclr!MethodDesc::JitCompileCode + 395 at F:\workspace\_work\1\s\src\vm\prestub.cpp:782
000000001C72ACA0 000007FEE5EF0106 coreclr!MethodDesc::PrepareILBasedCode + 250 at F:\workspace\_work\1\s\src\vm\prestub.cpp:399
000000001C72ACD0 000007FEE5FE3990 coreclr!CodeVersionManager::PublishVersionableCodeIfNecessary + 280 at F:\workspace\_work\1\s\src\vm\codeversion.cpp:1800
000000001C72AE40 000007FEE5ED0736 coreclr!MethodDesc::DoPrestub + 694 at F:\workspace\_work\1\s\src\vm\prestub.cpp:1985
000000001C72AF00 000007FEE5ED0253 coreclr!PreStubWorker + 1123 at F:\workspace\_work\1\s\src\vm\prestub.cpp:1811
000000001C72AF98                  [PrestubMethodFrame: 000000001c72af98] System.Linq.Expressions.dll!System.Linq.Expressions.Expression`1[[System.__Canon, System.Private.CoreLib]].get_PublicType()
000000001C72B110 000007FEE5FCBFD5 coreclr!ThePreStub + 85 at F:\workspace\_work\1\s\src\vm\amd64\ThePreStubAMD64.asm:22
000000001C72B1C0 000007fe877f72b3 System.Linq.Expressions.dll!System.Linq.Expressions.Expression.Quote(System.Linq.Expressions.Expression) + 195

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Nov 9, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful No un-ignored checks.

@jkotas
Copy link
Member

jkotas commented Nov 9, 2019

That is @fadimounir change dotnet/coreclr#26262. Could you please revert it in CoreCLR? (I am going offline in a minute.)

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Nov 9, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful No un-ignored checks.

@stephentoub
Copy link
Member

Could you please revert it in CoreCLR?

Will do.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Nov 9, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful No un-ignored checks.

@fadimounir
Copy link

@stephentoub thanks for reverting this. I'm suspecting some gc-hole somewhere. I'll investigate further next week.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Nov 9, 2019

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • All Checks Successful Unsuccessful checks: corefx-ci (MacOS Build x64_Debug), corefx-ci (Linux Build arm64_Debug), corefx-ci (Linux Build musl_x64_Debug), corefx-ci (Linux Build musl_arm64_Debug), corefx-ci (Linux Build x64_Debug), corefx-ci (Linux Build arm_Debug), corefx-ci (Linux Build wasm_Release), corefx-ci (Linux Build RedHat6_x64_Release)

@jkotas
Copy link
Member

jkotas commented Nov 9, 2019

I am going to revert the ilasm change that is breaking the build.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Nov 9, 2019

Auto-Merge Status

This pull request has been merged because the following merge policies have succeeded.

  • ✔️ All Checks Successful Succeeded - Successful checks: corefx-ci, corefx-ci (Windows Build NETFX_x86_Release), corefx-ci (Windows Build x86_Release), corefx-ci (Windows Build x64_Debug), corefx-ci (Windows Packaging All Configurations x64_Debug), corefx-ci (MacOS Build x64_Debug), corefx-ci (Linux Build arm64_Debug), corefx-ci (Linux Build musl_arm64_Debug), corefx-ci (Linux Build musl_x64_Debug), corefx-ci (Linux Build arm_Debug), corefx-ci (Linux Build x64_Debug), corefx-ci (Linux Build wasm_Release), corefx-ci (Linux Build RedHat6_x64_Release)

@stephentoub stephentoub force-pushed the darc-master-20bb3772-64f1-449c-93e6-df6812675e39 branch from f1e7724 to 9d51358 Compare November 9, 2019 19:01
@dotnet-maestro dotnet-maestro bot merged commit 2e513ec into master Nov 9, 2019
@dotnet-maestro dotnet-maestro bot deleted the darc-master-20bb3772-64f1-449c-93e6-df6812675e39 branch November 9, 2019 20:33
@stephentoub
Copy link
Member

Finally. :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants