This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
Fix the build after System.Memory update #1408
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This just fixes compilation errors. I think the tests still fail with span being on the heap. In addition, there are massive breaks as AsSpan seem to be not implemented. I think it has something to do with the adaptive package for System.Memory being messed up. |
ahsonkhan
reviewed
Mar 31, 2017
| @@ -60,7 +60,7 @@ public static int Seek(ReadCursor begin, ReadCursor end, out ReadCursor result, | |||
| var segment = segmentPart.Segment; | |||
| var span = segment.Buffer.Span.Slice(segmentPart.Start, segmentPart.Length); | |||
|
|
|||
| int index = span.IndexOfAny(byte0, byte1, byte2); | |||
| int index = System.SpanExtensions.IndexOfAny(span, byte0, byte1, byte2); | |||
There was a problem hiding this comment.
These changes are unnecessary since we have IndexOfAny now, as of dotnet/corefx#17357
|
closing |
|
OK, so it seems like #17744 will fix this. Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @ahsonkhan, @shiftylogic, @davidfowl